Merge branch 'feature/credit-app-acceptance'

Author: mg-sn

src/main/kotlin/com/senacor/lpt/service/creditapplication/CreditApplication.kt

@@ -18,7 +18,11 @@ data class CreditApplication(
     val monthlyNetIncome: BigDecimal,
     val monthlyExpenses: BigDecimal,
     val creditDecision: CreditDecisionType,
-)
+    val accepted: Boolean,
+) {
+    fun accept() = also { check(!accepted) { "Credit application already accepted" } }
+        .let { copy(accepted = true) }
+}
 
 fun toFirestoreModel(value: CreditApplication) =
     CreditApplicationFirestoreModel(
@@ -30,7 +34,8 @@ fun toFirestoreModel(value: CreditApplication) =
         occupation = value.occupation,
         monthlyNetIncomeInCents = toCents(value.monthlyNetIncome),
         monthlyExpensesInCents = toCents(value.monthlyExpenses),
-        creditDecision = value.creditDecision
+        creditDecision = value.creditDecision,
+        accepted = value.accepted,
     )
 
 fun fromFirestoreModel(value: CreditApplicationFirestoreModel) =
@@ -43,7 +48,8 @@ fun fromFirestoreModel(value: CreditApplicationFirestoreModel) =
         occupation = value.occupation!!,
         monthlyNetIncome = fromCents(value.monthlyNetIncomeInCents!!),
         monthlyExpenses = fromCents(value.monthlyExpensesInCents!!),
-        creditDecision = value.creditDecision!!
+        creditDecision = value.creditDecision!!,
+        accepted = value.accepted!!
     )
 
 private fun toCents(value: BigDecimal) = value.times(BigDecimal(100)).toLong()

src/main/kotlin/com/senacor/lpt/service/creditapplication/CreditApplicationRequest.kt

@@ -21,6 +21,7 @@ class CreditApplicationRequest(
         occupation = occupation,
         monthlyNetIncome = monthlyNetIncome,
         monthlyExpenses = monthlyExpenses,
-        creditDecision = CreditDecisionType.PENDING
+        creditDecision = CreditDecisionType.PENDING,
+        accepted = false
     )
 }

src/main/kotlin/com/senacor/lpt/service/creditapplication/CreditApplicationsController.kt

@@ -6,14 +6,15 @@ import com.senacor.lpt.service.creditapplication.decision.CreditDecisionService
 import com.senacor.lpt.service.creditapplication.repository.CreditApplicationRepository
 import org.slf4j.Logger
 import org.slf4j.LoggerFactory.getLogger
+import org.springframework.http.HttpStatus
+import org.springframework.web.bind.annotation.CrossOrigin
 import org.springframework.web.bind.annotation.PathVariable
 import org.springframework.web.bind.annotation.PostMapping
 import org.springframework.web.bind.annotation.RequestBody
 import org.springframework.web.bind.annotation.RequestMapping
+import org.springframework.web.bind.annotation.ResponseStatus
 import org.springframework.web.bind.annotation.RestController
-import org.springframework.web.bind.annotation.CrossOrigin
 import reactor.core.publisher.Mono
-import java.util.*
 
 @RestController
 @CrossOrigin(origins = ["*"])
@@ -34,22 +35,28 @@ class CreditApplicationsController(
             .map { creditDecisionCustomerTuple ->
                 // TODO: add a proper application/domain layer instead of just talking to a repo
                 logger.info("Selected credit decision and customer")
-                println("Selected credit decision and customer")
                 request.toDomain().copy(creditDecision = creditDecisionCustomerTuple.t1)
             }.flatMap { domainModel ->
                 logger.info("Saving credit decision to database")
-                println("Saving credit decision to database")
                 creditApplicationRepository.save(toFirestoreModel(domainModel))
             }.map { savedCreditApplication ->
                 logger.info("Received new credit decision request with id {}", savedCreditApplication.id)
-                println(String.format("Received new credit decision request with id %s", savedCreditApplication.id))
                 CreditApplicationResponse(
                     savedCreditApplication.creditDecision!!, savedCreditApplication.id!!
                 )
             }
 
     @PostMapping("/{id}")
-    fun acceptCreditApplication(@PathVariable id: String) {
-        // TODO: accept credit and create credit agreement
-    }
+    @ResponseStatus(HttpStatus.ACCEPTED)
+    fun acceptCreditApplication(@PathVariable id: String) =
+        creditApplicationRepository.findById(id)
+            .map { fromFirestoreModel(it) }
+            .map {
+                logger.info("Accepting credit application with id {}", it.id)
+                it.accept()
+            }.map { toFirestoreModel(it) }
+            .flatMap {
+                logger.info("Saving credit decision with id {} to database", it.id)
+                creditApplicationRepository.save(it)
+            }
 }

src/main/kotlin/com/senacor/lpt/service/creditapplication/repository/CreditApplicationFirestoreModel.kt

@@ -17,4 +17,5 @@ class CreditApplicationFirestoreModel(
     var monthlyNetIncomeInCents: Long? = null,
     var monthlyExpensesInCents: Long? = null,
     var creditDecision: CreditDecisionType? = null,
+    var accepted: Boolean? = null,
 )

src/test/kotlin/com/senacor/lpt/service/creditapplication/repository/CreditApplicationFirestoreTemplateIntegrationTest.kt

@@ -33,7 +33,8 @@ class CreditApplicationFirestoreTemplateIntegrationTest {
             "Arbeiter",
             BigDecimal("3000.00"),
             BigDecimal("2500.00"),
-            CreditDecisionType.PENDING
+            CreditDecisionType.PENDING,
+            accepted = false
         )
 
         firestoreTemplate.save(toFirestoreModel(creditApplication)).block()

src/test/kotlin/com/senacor/lpt/service/creditapplication/repository/CreditApplicationRepositoryIntegrationTest.kt

@@ -31,7 +31,8 @@ class CreditApplicationRepositoryIntegrationTest {
             "Arbeiter",
             BigDecimal("3000.00"),
             BigDecimal("2500.00"),
-            CreditDecisionType.PENDING
+            CreditDecisionType.PENDING,
+            accepted = false
         )
 
         repository.save(toFirestoreModel(creditApplication)).block()