Use asynchronous operations everywhere to avoid blocking the main thread #948
Conversation
| function promisifySave(nodeStyleFunction) { | ||
| return function () { | ||
| const args = Array.prototype.slice.call(arguments); | ||
| return new Promise(function (resolve) { | ||
| args.push(function (err, data) { | ||
| resolve(data); | ||
| }); | ||
| nodeStyleFunction.apply(null, args); | ||
| }); | ||
| }; | ||
| } |
There was a problem hiding this comment.
This utility function had exactly one usage, where now a .catch(() => '') is utilized in its place.
|
Just fyi @sebhildebrandt systeminformation causes major performance issues and event loop deadlocks when used in server applications. This PR fixes it. https://nodejs.org/en/learn/asynchronous-work/dont-block-the-event-loop We're running this fork at @getumbrel with great results but we'd love to come back to upstream once this is merged 🙏 |
|
@sebhildebrandt would you be able to include this in the next release? |
|
@Spartan-Hex-Shadow, @dcodeIO , @lukechilds ... the next major release (6.0) is a complete rewrite (TS) where we do not have any sync functions. This should then be solved. |
|
@sebhildebrandt Even though it is fixed in the next major release in a more rigorous way, perhaps there would be no harm in having it fixed in the current major release? Unless you see any problems with this PR, of course. |
|
Merged master into this branch, so it now includes the fix for GHSA-cvv5-9h9w-qp2m. It appears that one new sync call has been introduced to master since, and it looks like it affects the public API, so all I could reasonably do was add a TODO. |
|
@sebhildebrandt can we get this merged as an incremental v5 release? |
| // TODO: Shouldn't be synchronous but is part of the public API | ||
| const stdout = execSync('date +%Z && date +%z && ls -l /etc/localtime 2>/dev/null', util.execOptsLinux); |
There was a problem hiding this comment.
I'm not sure this will work since the import of "execSync" is removed above?
5 participants
This PR removes all blocking operations (
child_process.execSyncandfs.readSync) from the library and replaces them with asynchronous equivalents while keeping the public API intact.The diff is intentionally boring, focusing solely on this change and minor related cleanup to minimize the risk of introducing accidental breakage.
Fixes #873. Keep it up!