Skip to content

Commit c2fcb8f

Browse files
sebastianbergmannsebastianbergmann
committed
Closes #5183 
1 parent a9db916 commit c2fcb8f

23 files changed

+40
-31
lines changed

‎ChangeLog-10.0.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@
22

33
All notable changes of the PHPUnit 10.0 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
44

5+
## [10.0.7] - 2023-MM-DD
6+
7+
### Changed
8+
9+
* The `PHPUnit\Event\Test\AssertionSucceeded::value()` method is now deprecated and always returns `''`
10+
11+
### Fixed
12+
13+
* [#5183](https://github.com/sebastianbergmann/phpunit/issues/5183): Values used in assertions are exported for `Test\AssertionSucceeded` events
14+
515
## [10.0.6] - 2023-02-08
616

717
### Fixed
@@ -173,6 +183,7 @@ All notable changes of the PHPUnit 10.0 release series are documented in this fi
173183
* PHP 7.3, PHP 7.4, and PHP 8.0 are no longer supported
174184
* `phpunit/php-code-coverage` [no longer supports PHPDBG and Xdebug 2](https://github.com/sebastianbergmann/php-code-coverage/blob/10.0.0/ChangeLog.md#1000---2023-02-03)
175185

186+
[10.0.7]: https://github.com/sebastianbergmann/phpunit/compare/10.0.6...10.0
176187
[10.0.6]: https://github.com/sebastianbergmann/phpunit/compare/10.0.5...10.0.6
177188
[10.0.5]: https://github.com/sebastianbergmann/phpunit/compare/10.0.4...10.0.5
178189
[10.0.4]: https://github.com/sebastianbergmann/phpunit/compare/10.0.3...10.0.4

‎src/Event/Emitter/DispatchingEmitter.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ public function testAssertionSucceeded(mixed $value, Constraint\Constraint $cons
403403
$this->dispatcher->dispatch(
404404
new Test\AssertionSucceeded(
405405
$this->telemetryInfo(),
406-
(new Exporter)->export($value),
406+
'',
407407
$constraint->toString(),
408408
$constraint->count(),
409409
$message,

‎src/Event/Events/Test/Assertion/AssertionSucceeded.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919
final class AssertionSucceeded implements Event
2020
{
2121
private readonly Telemetry\Info $telemetryInfo;
22-
private readonly string $value;
2322
private readonly string $constraint;
2423
private readonly int $count;
2524
private readonly string $message;
2625

2726
public function __construct(Telemetry\Info $telemetryInfo, string $value, string $constraint, int $count, string $message)
2827
{
2928
$this->telemetryInfo = $telemetryInfo;
30-
$this->value = $value;
3129
$this->constraint = $constraint;
3230
$this->count = $count;
3331
$this->message = $message;
@@ -38,9 +36,12 @@ public function telemetryInfo(): Telemetry\Info
3836
return $this->telemetryInfo;
3937
}
4038

39+
/**
40+
* @deprecated https://github.com/sebastianbergmann/phpunit/issues/5183
41+
*/
4142
public function value(): string
4243
{
43-
return $this->value;
44+
return '';
4445
}
4546

4647
public function count(): int
@@ -65,9 +66,8 @@ public function asString(): string
6566
}
6667

6768
return sprintf(
68-
'Assertion Succeeded (Constraint: %s, Value: %s%s)',
69+
'Assertion Succeeded (Constraint: %s%s)',
6970
$this->constraint,
70-
$this->value,
7171
$message
7272
);
7373
}

‎tests/end-to-end/event/invalid-coverage-metadata.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Test Suite Started (default, 1 test)
4040
Test Suite Started (PHPUnit\TestFixture\Event\InvalidCoverageMetadata\InvalidCoverageMetadataTest, 1 test)
4141
Test Preparation Started (PHPUnit\TestFixture\Event\InvalidCoverageMetadata\InvalidCoverageMetadataTest::testOne)
4242
Test Prepared (PHPUnit\TestFixture\Event\InvalidCoverageMetadata\InvalidCoverageMetadataTest::testOne)
43-
Assertion Succeeded (Constraint: is true, Value: true)
43+
Assertion Succeeded (Constraint: is true)
4444
Test Passed (PHPUnit\TestFixture\Event\InvalidCoverageMetadata\InvalidCoverageMetadataTest::testOne)
4545
Test Triggered PHPUnit Warning (PHPUnit\TestFixture\Event\InvalidCoverageMetadata\InvalidCoverageMetadataTest::testOne)
4646
Class "PHPUnit\TestFixture\Event\InvalidCoverageMetadata\This\Does\Not\Exist" is not a valid target for code coverage

‎tests/end-to-end/event/phar-extension.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Test Suite Started (default, 1 test)
3838
Test Suite Started (PHPUnit\TestFixture\Event\MyExtension\Test, 1 test)
3939
Test Preparation Started (PHPUnit\TestFixture\Event\MyExtension\Test::testOne)
4040
Test Prepared (PHPUnit\TestFixture\Event\MyExtension\Test::testOne)
41-
Assertion Succeeded (Constraint: is true, Value: true)
41+
Assertion Succeeded (Constraint: is true)
4242
Test Passed (PHPUnit\TestFixture\Event\MyExtension\Test::testOne)
4343
Test Finished (PHPUnit\TestFixture\Event\MyExtension\Test::testOne)
4444
Test Suite Finished (PHPUnit\TestFixture\Event\MyExtension\Test, 1 test)

‎tests/end-to-end/event/php-deprecated.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Test Preparation Started (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest::te
4242
Test Prepared (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest::testDeprecatedPhpFeature)
4343
Test Triggered PHP Deprecation (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest::testDeprecatedPhpFeature)
4444
defined(): Passing null to parameter #1 ($constant_name) of type string is deprecated
45-
Assertion Succeeded (Constraint: is true, Value: true)
45+
Assertion Succeeded (Constraint: is true)
4646
Test Passed (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest::testDeprecatedPhpFeature)
4747
Test Finished (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest::testDeprecatedPhpFeature)
4848
Test Suite Finished (PHPUnit\TestFixture\Event\DeprecatedPhpFeatureTest, 1 test)

‎tests/end-to-end/event/php-notice.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Test Preparation Started (PHPUnit\TestFixture\Event\PhpNoticeTest::testPhpNotice
3636
Test Prepared (PHPUnit\TestFixture\Event\PhpNoticeTest::testPhpNotice)
3737
Test Triggered PHP Notice (PHPUnit\TestFixture\Event\PhpNoticeTest::testPhpNotice)
3838
Only variables should be assigned by reference
39-
Assertion Succeeded (Constraint: is true, Value: true)
39+
Assertion Succeeded (Constraint: is true)
4040
Test Passed (PHPUnit\TestFixture\Event\PhpNoticeTest::testPhpNotice)
4141
Test Finished (PHPUnit\TestFixture\Event\PhpNoticeTest::testPhpNotice)
4242
Test Suite Finished (PHPUnit\TestFixture\Event\PhpNoticeTest, 1 test)

‎tests/end-to-end/event/php-warning.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Test Preparation Started (PHPUnit\TestFixture\Event\PhpWarningTest::testPhpWarni
3636
Test Prepared (PHPUnit\TestFixture\Event\PhpWarningTest::testPhpWarning)
3737
Test Triggered PHP Warning (PHPUnit\TestFixture\Event\PhpWarningTest::testPhpWarning)
3838
Undefined variable $b
39-
Assertion Succeeded (Constraint: is true, Value: true)
39+
Assertion Succeeded (Constraint: is true)
4040
Test Passed (PHPUnit\TestFixture\Event\PhpWarningTest::testPhpWarning)
4141
Test Finished (PHPUnit\TestFixture\Event\PhpWarningTest::testPhpWarning)
4242
Test Suite Finished (PHPUnit\TestFixture\Event\PhpWarningTest, 1 test)

‎tests/end-to-end/event/phpunit-deprecated.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Test Preparation Started (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest
3636
Test Prepared (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest::testDeprecatedPhpunitFeature)
3737
Test Triggered PHPUnit Deprecation (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest::testDeprecatedPhpunitFeature)
3838
message
39-
Assertion Succeeded (Constraint: is true, Value: true)
39+
Assertion Succeeded (Constraint: is true)
4040
Test Passed (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest::testDeprecatedPhpunitFeature)
4141
Test Finished (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest::testDeprecatedPhpunitFeature)
4242
Test Suite Finished (PHPUnit\TestFixture\Event\DeprecatedPhpunitFeatureTest, 1 test)

‎tests/end-to-end/event/phpunit-warning.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Test Preparation Started (PHPUnit\TestFixture\Event\PhpunitWarningTest::testPhpu
3636
Test Prepared (PHPUnit\TestFixture\Event\PhpunitWarningTest::testPhpunitWarning)
3737
Test Triggered PHPUnit Warning (PHPUnit\TestFixture\Event\PhpunitWarningTest::testPhpunitWarning)
3838
message
39-
Assertion Succeeded (Constraint: is true, Value: true)
39+
Assertion Succeeded (Constraint: is true)
4040
Test Passed (PHPUnit\TestFixture\Event\PhpunitWarningTest::testPhpunitWarning)
4141
Test Finished (PHPUnit\TestFixture\Event\PhpunitWarningTest::testPhpunitWarning)
4242
Test Suite Finished (PHPUnit\TestFixture\Event\PhpunitWarningTest, 1 test)

0 commit comments

Comments
 (0)