fix(slack)!: Remove usage of winston logger (#72)

Author: bbckr

plugins/slack-catalog-backend/package.json

@@ -26,7 +26,6 @@
     "postpack": "backstage-cli package postpack"
   },
   "dependencies": {
-    "@backstage/backend-common": "^0.24.0",
     "@backstage/backend-plugin-api": "^0.8.0",
     "@backstage/catalog-model": "^1.6.0",
     "@backstage/config": "^1.2.0",

plugins/slack-catalog-backend/src/SlackUserProcessor.ts

@@ -2,6 +2,7 @@
  * Copyright SeatGeek
  * Licensed under the terms of the Apache-2.0 license. See LICENSE file in project root for terms.
  */
+import { LoggerService } from '@backstage/backend-plugin-api';
 import { Entity, isUserEntity } from '@backstage/catalog-model';
 import { Config } from '@backstage/config';
 import { LocationSpec } from '@backstage/plugin-catalog-common';
@@ -11,7 +12,6 @@ import type {
 } from '@backstage/plugin-catalog-node';
 import { WebClient } from '@slack/web-api';
 import { Member } from '@slack/web-api/dist/types/response/UsersListResponse';
-import { Logger } from 'winston';
 
 const SLACK_USER_LIMIT = 1000;
 
@@ -23,7 +23,7 @@ const SLACK_USER_LIMIT = 1000;
  */
 export class SlackUserProcessor implements CatalogProcessor {
   private readonly slack: WebClient;
-  private readonly logger: Logger;
+  private readonly logger: LoggerService;
   private cacheLoaded: boolean;
   private userLookup: Map<string, Member>;
   // guarantee that users are loaded only once
@@ -86,7 +86,10 @@ export class SlackUserProcessor implements CatalogProcessor {
     return this.userLookup;
   }
 
-  static fromConfig(config: Config, logger: Logger): SlackUserProcessor[] {
+  static fromConfig(
+    config: Config,
+    logger: LoggerService,
+  ): SlackUserProcessor[] {
     const slackToken = config.getOptionalString('slackCatalog.token');
     if (!slackToken) {
       logger.warn(
@@ -97,7 +100,7 @@ export class SlackUserProcessor implements CatalogProcessor {
     return [new SlackUserProcessor(new WebClient(slackToken), logger)];
   }
 
-  constructor(slack: WebClient, logger: Logger) {
+  constructor(slack: WebClient, logger: LoggerService) {
     this.slack = slack;
     this.logger = logger;
     this.userLookup = new Map();

plugins/slack-catalog-backend/src/module.ts

@@ -2,7 +2,6 @@
  * Copyright SeatGeek
  * Licensed under the terms of the Apache-2.0 license. See LICENSE file in project root for terms.
  */
-import { loggerToWinstonLogger } from '@backstage/backend-common';
 import {
   coreServices,
   createBackendModule,
@@ -32,10 +31,7 @@ export const catalogModuleSlackUserProcessor = createBackendModule({
           return;
         }
         catalog.addProcessor(
-          new SlackUserProcessor(
-            new WebClient(slackToken),
-            loggerToWinstonLogger(logger),
-          ),
+          new SlackUserProcessor(new WebClient(slackToken), logger),
         );
       },
     });

yarn.lock

@@ -12267,7 +12267,7 @@
   resolved "https://registry.yarnpkg.com/@types/range-parser/-/range-parser-1.2.7.tgz#50ae4353eaaddc04044279812f52c8c65857dbcb"
   integrity sha512-hKormJbkJqzQGhziax5PItDUTMAM9uE2XXQmM37dyd4hVM+5aVl7oVxMVUiVQn2oCQFN/LKCZdvSM0pFRqbSmQ==
 
-"@types/react-dom@*", "@types/react-dom@<18.0.0":
+"@types/react-dom@*", "@types/react-dom@<18.0.0", "@types/react-dom@^17":
   version "17.0.25"
   resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-17.0.25.tgz#e0e5b3571e1069625b3a3da2b279379aa33a0cb5"
   integrity sha512-urx7A7UxkZQmThYA4So0NelOVjx3V4rNFVJwp0WZlbIK5eM4rNJDiN3R/E9ix0MBh6kAEojk/9YL+Te6D9zHNA==