fix update.path nil pointer #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steiler
requested review from
alexandernorth,
hansthienpondt,
henderiw and
karimra
as code owners
Closed
hansthienpondt
approved these changes
Nov 4, 2025
Contributor
hansthienpondt
left a comment
hansthienpondt
left a comment
There was a problem hiding this comment.
LGTM, deviation testing are failing because of known issue.
| name string | ||
| // updates is nil if the intent did not exist. | ||
| updates treetypes.UpdateSlice | ||
| updates []*treetypes.PathAndUpdate |
Contributor
There was a problem hiding this comment.
is there a specific reason why we use a pointer type in the slice? There is not much performance gain and it risks more nil pointer issues in the future
Collaborator
Author
There was a problem hiding this comment.
Habit I guess... but you're right it contains just pointers so lets make store the values.
alexandernorth
approved these changes
Nov 5, 2025
Contributor
alexandernorth
left a comment
alexandernorth
left a comment
There was a problem hiding this comment.
LGTM - we plan to discuss code style (pointers in slices vs not) later
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.