Skip to content

Conversation

@steiler
Copy link
Collaborator

@steiler steiler commented Aug 6, 2025

Change some of the functionality to visitors

  • BlameConfig
  • MarkOwnerDelete

@steiler steiler requested a review from alexandernorth August 11, 2025 13:06
Copy link
Contributor

@alexandernorth alexandernorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steiler steiler merged commit 110d9ad into main Aug 12, 2025
6 checks passed
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 81.92771% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/datastore/transaction_rpc.go 0.00% 5 Missing ⚠️
pkg/datastore/datastore_rpc.go 0.00% 4 Missing ⚠️
pkg/tree/visitor_mark_owner_delete.go 76.47% 4 Missing ⚠️
pkg/tree/sharedEntryAttributes.go 83.33% 0 Missing and 1 partial ⚠️
pkg/tree/visitor_blame_config.go 97.87% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants