Skip to content

Conversation

@steiler
Copy link
Collaborator

@steiler steiler commented Jul 23, 2025

  • Change the EntryVisitor used in the sharedEntryAttributes.Walk() from a funtion to an interface, which allows for the EntryVisitor to keep state.
  • Introduce validation statistics indication how many of the different validation types where executed

Copy link
Contributor

@hansthienpondt hansthienpondt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansthienpondt hansthienpondt merged commit 3be3a89 into main Aug 6, 2025
6 checks passed
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 58.08824% with 57 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/tree/types/validation_stats.go 28.88% 32 Missing ⚠️
pkg/tree/types/update_insert_flags.go 0.00% 11 Missing ⚠️
pkg/tree/sharedEntryAttributes.go 80.43% 9 Missing ⚠️
pkg/datastore/transaction_rpc.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants