Fixes for NETCONF key ordering and leaflists #308

alexandernorth · 2025-07-21T15:06:08Z

This PR addresses the following:

adds a default value for syncing to avoid panics if the value is set <= 0
fixes case where a NETCONF replace action on a leaflist would result in dropping non-key elements from the parent and also fixes the ordering of the elements
incoming leaflist values were previously treated as strings causing equality checks to fail and commits to be sent to the device, leaflist values are now converted to the correct type in the tree

…lows schema order when doing netconf replace, EqualTypedValues ignores order of elements in LeafList

…gs are missing

alexandernorth · 2025-07-22T13:54:24Z

go test -cover ./...

        github.com/sdcio/data-server            coverage: 0.0% of statements
        github.com/sdcio/data-server/client             coverage: 0.0% of statements
        github.com/sdcio/data-server/client/cmd         coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockcacheclient              coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocknetconf          coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockschema           coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockschemaclientbound                coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocktarget           coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocktreeentry                coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/cache          coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/config         coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/datastore      (cached)        coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/clients/schema               coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/datastore/target       (cached)        coverage: 7.3% of statements
ok      github.com/sdcio/data-server/pkg/datastore/target/netconf       (cached)        coverage: 67.4% of statements
        github.com/sdcio/data-server/pkg/datastore/target/netconf/driver/scrapligo              coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/target/netconf/types         coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/types                coverage: 0.0% of statements
?       github.com/sdcio/data-server/pkg/dslog  [no test files]
        github.com/sdcio/data-server/pkg/schema         coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/server         coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/tree   (cached)        coverage: 80.0% of statements
?       github.com/sdcio/data-server/pkg/tree/importer  [no test files]
ok      github.com/sdcio/data-server/pkg/tree/importer/json     (cached)        coverage: 46.2% of statements
ok      github.com/sdcio/data-server/pkg/tree/importer/proto    (cached)        coverage: 85.7% of statements
ok      github.com/sdcio/data-server/pkg/tree/importer/xml      (cached)        coverage: 93.3% of statements
        github.com/sdcio/data-server/pkg/tree/tree_persist              coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/tree/types             coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/utils  0.419s  coverage: 12.6% of statements
        github.com/sdcio/data-server/pkg/utils/testhelper               coverage: 0.0% of statements
        github.com/sdcio/data-server/tests/sdcioygot            coverage: 0.0% of statements

codecov · 2025-07-22T15:20:20Z

Codecov Report

Attention: Patch coverage is 45.33333% with 41 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/config/datastore.go	0.00%	14 Missing ⚠️
pkg/tree/xml.go	45.83%	12 Missing and 1 partial ⚠️
...kg/datastore/target/netconf/xml2SchemapbAdapter.go	53.84%	9 Missing and 3 partials ⚠️
pkg/datastore/transaction_rpc.go	0.00%	1 Missing ⚠️
pkg/utils/value.go	90.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alexandernorth · 2025-07-22T15:52:45Z

go test -cover ./...

        github.com/sdcio/data-server            coverage: 0.0% of statements
        github.com/sdcio/data-server/client             coverage: 0.0% of statements
        github.com/sdcio/data-server/client/cmd         coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockcacheclient              coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocknetconf          coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockschema           coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mockschemaclientbound                coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocktarget           coverage: 0.0% of statements
        github.com/sdcio/data-server/mocks/mocktreeentry                coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/cache          coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/config         coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/datastore      (cached)        coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/clients/schema               coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/datastore/target       (cached)        coverage: 7.3% of statements
ok      github.com/sdcio/data-server/pkg/datastore/target/netconf       0.721s  coverage: 67.8% of statements
        github.com/sdcio/data-server/pkg/datastore/target/netconf/driver/scrapligo              coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/target/netconf/types         coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/datastore/types                coverage: 0.0% of statements
?       github.com/sdcio/data-server/pkg/dslog  [no test files]
        github.com/sdcio/data-server/pkg/schema         coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/server         coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/tree   (cached)        coverage: 80.0% of statements
?       github.com/sdcio/data-server/pkg/tree/importer  [no test files]
ok      github.com/sdcio/data-server/pkg/tree/importer/json     (cached)        coverage: 46.2% of statements
ok      github.com/sdcio/data-server/pkg/tree/importer/proto    (cached)        coverage: 85.7% of statements
ok      github.com/sdcio/data-server/pkg/tree/importer/xml      (cached)        coverage: 93.3% of statements
        github.com/sdcio/data-server/pkg/tree/tree_persist              coverage: 0.0% of statements
        github.com/sdcio/data-server/pkg/tree/types             coverage: 0.0% of statements
ok      github.com/sdcio/data-server/pkg/utils  (cached)        coverage: 18.8% of statements
        github.com/sdcio/data-server/pkg/utils/testhelper               coverage: 0.0% of statements
        github.com/sdcio/data-server/tests/sdcioygot            coverage: 0.0% of statements

steiler

lgtm

hansthienpondt

lgtm

alexandernorth added 3 commits July 14, 2025 10:17

validate sync interval value with default const added, ensure key fol…

232d395

…lows schema order when doing netconf replace, EqualTypedValues ignores order of elements in LeafList

WIP: implement fixes in the netconf replace case where non-key siblin…

3758562

…gs are missing

transformLeafList now converts type to correct typedvalue

4d3f09a

alexandernorth requested review from hansthienpondt, henderiw, karimra and steiler as code owners July 21, 2025 15:06

alexandernorth added 7 commits July 21, 2025 17:32

fix build error due to log.Tracef call

88c49c1

WIP removed call to add namespace to key elements and added TODOs

01ee200

resolved TODO regarding namespacing of key elements

d2721f7

add tests for XML2sdcpbConfigAdapter

355cfd2

add tests for XML2sdcpbConfigAdapter

b24e686

add tests for xml generation

937d8a3

indentation

018f57f

alexandernorth added 2 commits July 22, 2025 15:55

format document

5467e2d

add EqualTypedValues test

f603542

alexandernorth added 2 commits July 22, 2025 17:23

expand EqualTypedValues test

e8c027b

expand xml2sdcpbconfigadapter test

f986aa5

steiler approved these changes Jul 23, 2025

View reviewed changes

hansthienpondt approved these changes Jul 28, 2025

View reviewed changes

alexandernorth merged commit eeb6b0b into main Jul 28, 2025
5 checks passed

alexandernorth deleted the fix/netconf-replace-key-ordering branch July 28, 2025 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for NETCONF key ordering and leaflists #308

Fixes for NETCONF key ordering and leaflists #308

Uh oh!

alexandernorth commented Jul 21, 2025

Uh oh!

alexandernorth commented Jul 22, 2025

Uh oh!

codecov bot commented Jul 22, 2025

Uh oh!

alexandernorth commented Jul 22, 2025

Uh oh!

steiler left a comment

Uh oh!

hansthienpondt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fixes for NETCONF key ordering and leaflists #308

Fixes for NETCONF key ordering and leaflists #308

Uh oh!

Conversation

alexandernorth commented Jul 21, 2025

Uh oh!

alexandernorth commented Jul 22, 2025

Uh oh!

codecov bot commented Jul 22, 2025

Codecov Report

Uh oh!

alexandernorth commented Jul 22, 2025

Uh oh!

steiler left a comment

Choose a reason for hiding this comment

Uh oh!

hansthienpondt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants