escape non-metacharacters (XML spec) #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of metacharacters is not the same between XML schema and perl/python/go Regular Expressions.
The set of metacharacters for XML schema is:
.\?*+{}()[](reference)the set of metacharacters defined in go is:
\.+*?()|[]{}^$(go/libexec/src/regexp/regexp.go:714)To maintain compatibility, we need to force escape the difference in these two sets (
^and$).^is a bit special as it is a valid metacharacter as the first char after the opening of a character set ([^...) so we make sure not to escape it in this position