Migrate logging implementation #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandernorth
force-pushed
the
feature/logging-refactoring
branch
3 times, most recently
from
451677d to
cfbba53
Compare
alexandernorth
force-pushed
the
feature/logging-refactoring
branch
3 times, most recently
from
c875f90 to
c12e5ac
Compare
alexandernorth
requested review from
hansthienpondt,
henderiw,
karimra and
steiler
as code owners
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
steiler
reviewed
Oct 6, 2025
alexandernorth
force-pushed
the
feature/logging-refactoring
branch
from
40b6968 to
1aa4c27
Compare
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 10, 2025
steiler
reviewed
Oct 17, 2025
Collaborator
|
LGTM |
alexandernorth
force-pushed
the
feature/logging-refactoring
branch
from
1146035 to
a9afff7
Compare
…r.Logger and passed through context refactor setToDevice add context to convert-like functions aligned logs for incoming gnmi requests, adding method name to logger name and using json for format added additional names for sbi/target funcs added ctx params migrate to slog implement feedback use MarshalOptions to stop multiline proto formatting remove WithName grpc
alexandernorth
force-pushed
the
feature/logging-refactoring
branch
from
a9afff7 to
8f05f11
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help with observability, this PR migrates the existing logging framework to a
logr.Loggerbased one, which is passed to various functions through the context.This has the advantage that fields can be added to the logger as the application proceeds, adding relevant context to the log output and grouping together messages which belong to the same request/goroutine/...
It is also using structured logging which can help when integrating logs into observability tools.
This also refactors the netconf set function to have only one version of the code to handle setting to running or candidate stores, rather than two separate functions