Skip to content

Conversation

@steiler
Copy link
Collaborator

@steiler steiler commented May 22, 2025

Implements the BlameConfig(...) RPC

Depends on sdcio/sdc-protos#74, so go.mod must still be updated after new build of sdc-protos are published.

Copy link
Contributor

@hansthienpondt hansthienpondt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansthienpondt hansthienpondt merged commit 4d3b6b5 into main Jun 16, 2025
9 of 10 checks passed
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 51.94805% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/datastore/datastore_rpc.go 0.00% 18 Missing ⚠️
pkg/server/datastore.go 0.00% 16 Missing ⚠️
pkg/tree/sharedEntryAttributes.go 91.42% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants