remove rolebinding superceeded by clusterrolebinding #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandernorth
requested review from
hansthienpondt,
henderiw and
steiler
as code owners
Contributor
|
could we rebase ? than the lint issues disappear. |
alexandernorth
force-pushed
the
fix/remove-duplicate-rolebinding
branch
from
fabd233 to
7b30969
Compare
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two identical Cluster/RoleBindings of which the RoleBinding is not needed, and was missing a namespace. This PR deletes the unneeded one which should also fix deployments via Flux