Merge pull request #367 from sdcio/fix/panic-on-connection-timeout

henderiw · web-flow · commit 5b85a60cb788 · 2025-08-22T00:26:53.000+02:00
diff --git a/pkg/sdc/schemaserver/client/client.go b/pkg/sdc/schemaserver/client/client.go
@@ -113,7 +113,7 @@ func (r *client) Start(ctx context.Context) error {
         }
         if !conn.WaitForStateChange(dialCtx, s) {
             // context expired or canceled
-            if err := r.conn.Close(); err != nil {
+            if err := conn.Close(); err != nil {
 				log.Error("close error", "err", err)
 			}
             return fmt.Errorf("gRPC connect timeout; last state: %s", s.String())

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func (r *client) Start(ctx context.Context) error {`
`113`	`113`	`}`
`114`	`114`	`if !conn.WaitForStateChange(dialCtx, s) {`
`115`	`115`	`// context expired or canceled`
`116`		`- if err := r.conn.Close(); err != nil {`
	`116`	`+ if err := conn.Close(); err != nil {`
`117`	`117`	`log.Error("close error", "err", err)`
`118`	`118`	`}`
`119`	`119`	`return fmt.Errorf("gRPC connect timeout; last state: %s", s.String())`