random fixes

Author: schteppe

src/collision/Narrowphase.js

@@ -178,7 +178,7 @@ var bodiesOverlap_shapePositionB = vec2.create();
  * @param  {Body} bodyA
  * @param  {Body} bodyB
  * @return {Boolean}
- * @todo test
+ * @todo shape world transforms are wrong
  */
 Narrowphase.prototype.bodiesOverlap = function(bodyA, bodyB){
     var shapePositionA = bodiesOverlap_shapePositionA;

src/constraints/DistanceConstraint.js

@@ -107,7 +107,7 @@ function DistanceConstraint(bodyA,bodyB,options){
     // g = (xi - xj).dot(n)
     // dg/dt = (vi - vj).dot(n) = G*W = [n 0 -n 0] * [vi wi vj wj]'
 
-    // ...and if we were to include offset points (TODO for now):
+    // ...and if we were to include offset points:
     // g =
     //      (xj + rj - xi - ri).dot(n) - distance
     //

src/equations/FrictionEquation.js

@@ -39,7 +39,7 @@ function FrictionEquation(bodyA, bodyB, slipForce){
     this.t = vec2.create();
 
     /**
-     * A ContactEquation connected to this friction. The contact equations can be used to rescale the max force for the friction. If more than one contact equation is given, then the max force can be set to the average.
+     * ContactEquations connected to this friction equation. The contact equations can be used to rescale the max force for the friction. If more than one contact equation is given, then the max force can be set to the average.
      * @property contactEquations
      * @type {ContactEquation}
      */

src/world/World.js

@@ -961,9 +961,10 @@ World.prototype.runNarrowphase = function(np,bi,si,xi,ai,bj,sj,xj,aj,cm,glen){
  */
 World.prototype.addSpring = function(spring){
     this.springs.push(spring);
-    this.addSpringEvent.spring = spring;
-    this.emit(this.addSpringEvent);
-    this.addSpringEvent.spring = null;
+    var evt = this.addSpringEvent;
+    evt.spring = spring;
+    this.emit(evt);
+    evt.spring = null;
 };
 
 /**
@@ -995,9 +996,10 @@ World.prototype.addBody = function(body){
     if(this.bodies.indexOf(body) === -1){
         this.bodies.push(body);
         body.world = this;
-        this.addBodyEvent.body = body;
-        this.emit(this.addBodyEvent);
-        this.addBodyEvent.body = null;
+        var evt = this.addBodyEvent;
+        evt.body = body;
+        this.emit(evt);
+        evt.body = null;
     }
 };
 

test/collision/Narrowphase.js

@@ -346,3 +346,13 @@ exports.reset = function(test){
     test.done();
 };
 
+
+exports.bodiesOverlap = function(test){
+    bodyA.addShape(new Circle(1));
+    bodyB.addShape(new Circle(1));
+    test.ok(narrowphase.bodiesOverlap(bodyA, bodyB));
+    bodyB.position[0] = 10;
+    test.ok(!narrowphase.bodiesOverlap(bodyA, bodyB));
+    test.done();
+};
+