Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit cea961e

Browse files
committed
npz: do not sort keys, use archive/zip.File order
1 parent 55042cb commit cea961e

File tree

4 files changed

+10
-13
lines changed

4 files changed

+10
-13
lines changed

npz/npz_example_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ func ExampleOpen() {
3939
fmt.Printf("arr1: %v\n", f1)
4040

4141
// Output:
42-
// arr0.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
4342
// arr1.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[6 1]}}
43+
// arr0.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
4444
// arr0: [0 1 2 3 4 5]
4545
// arr1: [0 1 2 3 4 5]
4646
}
@@ -82,8 +82,8 @@ func ExampleReader() {
8282
fmt.Printf("arr1: %v\n", f1)
8383

8484
// Output:
85-
// arr0.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
8685
// arr1.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[6 1]}}
86+
// arr0.npy: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
8787
// arr0: [0 1 2 3 4 5]
8888
// arr1: [0 1 2 3 4 5]
8989
}

npz/reader.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"fmt"
1010
"io"
1111
"os"
12-
"sort"
1312

1413
"github.com/sbinet/npyio/npy"
1514
)
@@ -69,7 +68,6 @@ func Open(name string) (*Reader, error) {
6968
for i, f := range rz.File {
7069
keys[i] = f.Name
7170
}
72-
sort.Strings(keys)
7371

7472
return &Reader{
7573
r: r,
@@ -91,7 +89,6 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
9189
for i, f := range rz.File {
9290
keys[i] = f.Name
9391
}
94-
sort.Strings(keys)
9592

9693
return &Reader{
9794
r: r,
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
================================================================================
22
file: testdata/data_float64_corder.npz
3-
entry: arr0.npy
4-
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
5-
data = [0 1 2 3 4 5]
6-
73
entry: arr1.npy
84
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[6 1]}}
95
data = [0 1 2 3 4 5]
6+
7+
entry: arr0.npy
8+
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:false, Shape:[2 3]}}
9+
data = [0 1 2 3 4 5]
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
================================================================================
22
file: testdata/data_float64_forder.npz
3-
entry: arr0.npy
4-
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:true, Shape:[2 3]}}
5-
data = [0 1 2 3 4 5]
6-
73
entry: arr1.npy
84
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:true, Shape:[6 1]}}
95
data = [0 1 2 3 4 5]
6+
7+
entry: arr0.npy
8+
npy-header: Header{Major:1, Minor:0, Descr:{Type:<f8, Fortran:true, Shape:[2 3]}}
9+
data = [0 1 2 3 4 5]

0 commit comments

Comments
 (0)