[IMP] - Make one migration from 12.0.1 to 12.0.4

[RMV] - Remove empty file

[IMP] - Update no_update cron after migration

[IMP] - move contract template recurrence info to line level

[FIX] - Fix contract line model description

[IMP] - Link contracts to analytic accounts

[FIX] - Fix pylint

[IMP] - Move chatter and attachments from analytic account to contract

[IMP] - Move account_analytic_id to contract line level

[IMP] - Improve version check in migration script

[IMP] - Move contracts followers from analytic accounts

[ADD] - Add mail.activity.mixin to contract.contract model

remove data drop from migration scripts

[12.0][FIX] - Fix _init_last_date_invoiced

fix flake8

[ADD] - Update contributors list

Author: sbejaoui

contract/migrations/12.0.2.0.0/post-migration.py

@@ -3,22 +3,92 @@
 
 import logging
 
-from odoo import SUPERUSER_ID, api
+from openupgradelib import openupgrade
 
 _logger = logging.getLogger(__name__)
 
 
-def migrate(cr, version):
+def _set_finished_contract(cr):
+    _logger.info("set recurring_next_date to false for finished contract")
+    openupgrade.logged_query(
+        cr,
+        """
+        UPDATE account_analytic_account
+        SET    recurring_next_date=NULL
+        WHERE  recurring_next_date > date_end
+        """,
+    )
+
+
+def _move_contract_recurrence_info_to_contract_line(cr):
+    _logger.info("Move contract data to line level")
+    openupgrade.logged_query(
+        cr,
+        """
+    ALTER TABLE account_analytic_invoice_line
+        ADD COLUMN IF NOT EXISTS recurring_rule_type         VARCHAR(255),
+        ADD COLUMN IF NOT EXISTS recurring_invoicing_type    VARCHAR(255),
+        ADD COLUMN IF NOT EXISTS recurring_interval          INTEGER,
+        ADD COLUMN IF NOT EXISTS recurring_next_date         DATE,
+        ADD COLUMN IF NOT EXISTS date_start                  DATE,
+        ADD COLUMN IF NOT EXISTS date_end                    DATE
+    """,
+    )
+
+    openupgrade.logged_query(
+        cr,
+        """
+        UPDATE account_analytic_invoice_line AS contract_line
+        SET
+            recurring_rule_type=contract.recurring_rule_type,
+            recurring_invoicing_type=contract.recurring_invoicing_type,
+            recurring_interval=contract.recurring_interval,
+            recurring_next_date=contract.recurring_next_date,
+            date_start=contract.date_start,
+            date_end=contract.date_end
+        FROM
+            account_analytic_account AS contract
+        WHERE
+            contract.id=contract_line.analytic_account_id
+        """,
+    )
+
+
+def _move_contract_template_recurrence_info_to_contract_template_line(cr):
+    _logger.info("Move contract template data to line level")
+    openupgrade.logged_query(
+        cr,
+        """
+    ALTER TABLE account_analytic_contract_line
+        ADD COLUMN IF NOT EXISTS recurring_rule_type         VARCHAR(255),
+        ADD COLUMN IF NOT EXISTS recurring_invoicing_type    VARCHAR(255),
+        ADD COLUMN IF NOT EXISTS recurring_interval          INTEGER
+    """,
+    )
+
+    openupgrade.logged_query(
+        cr,
+        """
+    UPDATE account_analytic_contract_line AS contract_template_line
+    SET
+        recurring_rule_type=contract_template.recurring_rule_type,
+        recurring_invoicing_type=contract_template.recurring_invoicing_type,
+        recurring_interval=contract_template.recurring_interval
+    FROM
+        account_analytic_contract AS contract_template
+    WHERE
+        contract_template.id=contract_template_line.analytic_account_id
+    """,
+    )
+
+
+@openupgrade.migrate()
+def migrate(env, version):
     """
     set recurring_next_date to false for finished contract
     """
     _logger.info(">> Pre-Migration 12.0.2.0.0")
-    with api.Environment(cr, SUPERUSER_ID, {}) as env:
-        contracts = env["account.analytic.account"].search([])
-        finished_contract = contracts.filtered(
-            lambda c: not c.create_invoice_visibility
-        )
-        cr.execute(
-            "UPDATE account_analytic_account set recurring_next_date=null "
-            "where id in (%)" % ','.join(finished_contract.ids)
-        )
+    cr = env.cr
+    _set_finished_contract(cr)
+    _move_contract_recurrence_info_to_contract_line(cr)
+    _move_contract_template_recurrence_info_to_contract_template_line(cr)