fix: (IAC-1008) Explicitly Set the release_channel when Creating GKE Clusters #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the user sets
UNSPECIFIEDfor thekubernetes_channeldo not setrelease_channelto null and rely on the default value downstream. Instead we will be explicitly settingrelease_channelit to the value inkubernetes_channel.We are doing this because apparently there was a underlying GKE API change where setting the
release_channelto null would now default to theREGULARchannel. It was advised to no longer set this value to null. See this GitHub issue I opened against theterraform-google-modules/kubernetes-enginemoduleterraform-google-modules/terraform-google-kubernetes-engine#1620
They are working on getting the doc updated in the next module release.
Note:
kubernetes_channel: the variable we expose to users in this project to control the release channelrelease_channel: the parameter that controls the release channel in theterraform-google-modules/kubernetes-engine/google//modules/private-clustermoduleTests