Fix ansible tests

Author: twangboy

tests/pytests/integration/states/test_ansiblegate.py

@@ -3,6 +3,7 @@
 """
 
 import logging
+import os
 import shutil
 import textwrap
 
@@ -63,22 +64,59 @@ def ansible_inventory(ansible_inventory_directory, sshd_server, known_hosts_file
     return inventory
 
 
+def is_rocky_linux_8():
+    # ansible.builtin.dnf doesn't work with Rocky Linux 8 because ansible-core
+    # doesn't support Python 3.6 and lower starting with version 2.17
+    if os.path.exists("/etc/os-release"):
+        os_release_info = {}
+        with salt.utils.files.fopen("/etc/os-release") as f:
+            lines = f.readlines()
+            for line in lines:
+                if "=" in line:
+                    key, value = line.strip().split("=", 1)
+                    os_release_info[key] = value.strip('"')
+
+        if (
+            os_release_info.get("ID") == "rocky"
+            and os_release_info.get("VERSION_ID") == "8"
+        ):
+            return True
+    return False
+
+
 @pytest.mark.requires_sshd_server
 @pytest.mark.timeout_unless_on_windows(240)
 def test_ansible_playbook(salt_call_cli, ansible_inventory, tmp_path):
+    found_rocky = is_rocky_linux_8()
+    if found_rocky:
+        pytest.skip("ansible-core doesn't support dnf on Rocky Linux 8")
     rundir = tmp_path / "rundir"
     rundir.mkdir(exist_ok=True, parents=True)
     remove_contents = textwrap.dedent(
         """
     ---
     - hosts: all
       tasks:
-      - name: remove postfix
-        yum:
+      - name: remove postfix dnf
+        ansible.builtin.dnf:
+          name: postfix
+          state: absent
+        become: true
+        when: ansible_pkg_mgr == 'dnf'
+
+      - name: remove postfix yum
+        ansible.builtin.yum:
           name: postfix
           state: absent
         become: true
-        become_user: root
+        when: ansible_pkg_mgr == 'yum'
+
+      - name: remove postfix apt
+        ansible.builtin.apt:
+          name: postfix
+          state: absent
+        become: true
+        when: ansible_pkg_mgr == 'apt'
     """
     )
     remove_playbook = rundir / "remove.yml"
@@ -88,12 +126,26 @@ def test_ansible_playbook(salt_call_cli, ansible_inventory, tmp_path):
     ---
     - hosts: all
       tasks:
-      - name: install postfix
-        yum:
+      - name: install postfix dnf
+        ansible.builtin.dnf:
+          name: postfix
+          state: present
+        become: true
+        when: ansible_pkg_mgr == 'dnf'
+
+      - name: install postfix yum
+        ansible.builtin.yum:
+          name: postfix
+          state: present
+        become: true
+        when: ansible_pkg_mgr == 'yum'
+
+      - name: install postfix apt
+        ansible.builtin.apt:
           name: postfix
           state: present
         become: true
-        become_user: root
+        when: ansible_pkg_mgr == 'apt'
     """
     )
     install_playbook = rundir / "install.yml"