Rename JobEv::{Calc, Not} to {All, None} to match JobSvd

Author: termoshtt

lax/src/eig.rs

@@ -35,11 +35,11 @@ macro_rules! impl_eig_complex {
                 // eigenvalues are the eigenvalues computed with `A`.
                 let (jobvl, jobvr) = if calc_v {
                     match l {
-                        MatrixLayout::C { .. } => (JobEv::Calc, JobEv::Not),
-                        MatrixLayout::F { .. } => (JobEv::Not, JobEv::Calc),
+                        MatrixLayout::C { .. } => (JobEv::All, JobEv::None),
+                        MatrixLayout::F { .. } => (JobEv::None, JobEv::All),
                     }
                 } else {
-                    (JobEv::Not, JobEv::Not)
+                    (JobEv::None, JobEv::None)
                 };
                 let mut eigs: Vec<MaybeUninit<Self>> = unsafe { vec_uninit(n as usize) };
                 let mut rwork: Vec<MaybeUninit<Self::Real>> = unsafe { vec_uninit(2 * n as usize) };
@@ -143,11 +143,11 @@ macro_rules! impl_eig_real {
                 // `sgeev`/`dgeev`.
                 let (jobvl, jobvr) = if calc_v {
                     match l {
-                        MatrixLayout::C { .. } => (JobEv::Calc, JobEv::Not),
-                        MatrixLayout::F { .. } => (JobEv::Not, JobEv::Calc),
+                        MatrixLayout::C { .. } => (JobEv::All, JobEv::None),
+                        MatrixLayout::F { .. } => (JobEv::None, JobEv::All),
                     }
                 } else {
-                    (JobEv::Not, JobEv::Not)
+                    (JobEv::None, JobEv::None)
                 };
                 let mut eig_re: Vec<MaybeUninit<Self>> = unsafe { vec_uninit(n as usize) };
                 let mut eig_im: Vec<MaybeUninit<Self>> = unsafe { vec_uninit(n as usize) };

lax/src/eigh.rs

@@ -41,7 +41,7 @@ macro_rules! impl_eigh {
             ) -> Result<Vec<Self::Real>> {
                 assert_eq!(layout.len(), layout.lda());
                 let n = layout.len();
-                let jobz = if calc_v { JobEv::Calc } else { JobEv::Not };
+                let jobz = if calc_v { JobEv::All } else { JobEv::None };
                 let mut eigs: Vec<MaybeUninit<Self::Real>> = unsafe { vec_uninit(n as usize) };
 
                 $(
@@ -100,7 +100,7 @@ macro_rules! impl_eigh {
             ) -> Result<Vec<Self::Real>> {
                 assert_eq!(layout.len(), layout.lda());
                 let n = layout.len();
-                let jobz = if calc_v { JobEv::Calc } else { JobEv::Not };
+                let jobz = if calc_v { JobEv::All } else { JobEv::None };
                 let mut eigs: Vec<MaybeUninit<Self::Real>> = unsafe { vec_uninit(n as usize) };
 
                 $(

lax/src/flags.rs

@@ -64,15 +64,17 @@ impl NormType {
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 #[repr(u8)]
 pub enum JobEv {
-    Calc = b'V',
-    Not = b'N',
+    /// Calculate eigenvectors in addition to eigenvalues
+    All = b'V',
+    /// Do not calculate eigenvectors. Only calculate eigenvalues.
+    None = b'N',
 }
 
 impl JobEv {
     pub fn is_calc(&self) -> bool {
         match self {
-            JobEv::Calc => true,
-            JobEv::Not => false,
+            JobEv::All => true,
+            JobEv::None => false,
         }
     }