Merge pull request #205 from rust-ndarray/clippy

Clippy check

Author: termoshtt

.github/workflows/rust.yml

@@ -65,3 +65,11 @@ jobs:
       with:
         command: fmt
         args: -- --check
+
+  clippy:
+    runs-on: ubuntu-18.04
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions-rs/cargo@v1
+      with:
+        command: clippy

src/cholesky.rs

@@ -298,7 +298,7 @@ where
     fn factorizec_into(self, uplo: UPLO) -> Result<CholeskyFactorized<S>> {
         Ok(CholeskyFactorized {
             factor: self.cholesky_into(uplo)?,
-            uplo: uplo,
+            uplo,
         })
     }
 }
@@ -311,7 +311,7 @@ where
     fn factorizec(&self, uplo: UPLO) -> Result<CholeskyFactorized<OwnedRepr<A>>> {
         Ok(CholeskyFactorized {
             factor: self.cholesky(uplo)?,
-            uplo: uplo,
+            uplo,
         })
     }
 }

src/diagonal.rs

@@ -42,7 +42,7 @@ where
         S: DataMut<Elem = A>,
     {
         for (val, d) in a.iter_mut().zip(self.diag.iter()) {
-            *val = *val * *d;
+            *val *= *d;
         }
     }
 }

src/krylov/householder.rs

@@ -13,7 +13,7 @@ where
     A: Scalar + Lapack,
     S: DataMut<Elem = A>,
 {
-    assert!(x.len() > 0);
+    assert!(!x.is_empty());
     let norm = x.norm_l2();
     let alpha = -x[0].mul_real(norm / x[0].abs());
     x[0] -= alpha;

src/krylov/mgs.rs

@@ -51,7 +51,7 @@ impl<A: Scalar + Lapack> Orthogonalizer for MGS<A> {
         for i in 0..self.len() {
             let q = &self.q[i];
             let c = q.inner(&a);
-            azip!((a in &mut *a, &q in q) *a = *a - c * q);
+            azip!((a in &mut *a, &q in q) *a -= c * q);
             coef[i] = c;
         }
         let nrm = a.norm_l2();
@@ -88,7 +88,7 @@ impl<A: Scalar + Lapack> Orthogonalizer for MGS<A> {
             // Linearly dependent
             return AppendResult::Dependent(coef);
         }
-        azip!((a in &mut *a) *a = *a / A::from_real(nrm));
+        azip!((a in &mut *a) *a /= A::from_real(nrm));
         self.q.push(a.to_owned());
         AppendResult::Added(coef)
     }

src/lapack/cholesky.rs

@@ -1,7 +1,5 @@
 //! Cholesky decomposition
 
-use lapacke;
-
 use crate::error::*;
 use crate::layout::MatrixLayout;
 use crate::types::*;

src/lapack/eig.rs

@@ -1,6 +1,5 @@
 //! Eigenvalue decomposition for general matrices
 
-use lapacke;
 use num_traits::Zero;
 
 use crate::error::*;

src/lapack/eigh.rs

@@ -1,6 +1,5 @@
 //! Eigenvalue decomposition for Hermite matrices
 
-use lapacke;
 use num_traits::Zero;
 
 use crate::error::*;

src/lapack/least_squares.rs

@@ -1,6 +1,5 @@
 //! Least squares
 
-use lapacke;
 use ndarray::{ErrorKind, ShapeError};
 use num_traits::Zero;
 

src/lapack/mod.rs

@@ -1,5 +1,7 @@
 //! Define traits wrapping LAPACK routines
 
+#![allow(clippy::missing_safety_doc)]
+
 pub mod cholesky;
 pub mod eig;
 pub mod eigh;