Remove dead code warnings + remove "internal" from features.default

Author: blyxyas

Cargo.toml

@@ -58,7 +58,7 @@ rustc-semver = "1.1"
 rustc_tools_util = "0.3.0"
 
 [features]
-deny-warnings = ["clippy_lints/deny-warnings", "internal"]
+deny-warnings = ["clippy_lints/deny-warnings"]
 integration = ["tempfile"]
 internal = ["clippy_lints/internal", "tempfile"]
 

clippy_lints/src/utils/metadata_collector.rs

@@ -148,6 +148,7 @@ pub struct MetadataCollector {
 }
 
 impl MetadataCollector {
+    #[cfg(feature = "internal")]
     pub fn new() -> Self {
         Self {
             lints: BinaryHeap::<LintMetadata>::default(),
@@ -578,6 +579,7 @@ impl ClippyConfiguration {
     }
 }
 
+#[cfg(feature = "internal")]
 fn collect_configs() -> Vec<ClippyConfiguration> {
     crate::utils::conf::metadata::get_configuration_metadata()
 }