Fix double internal error

- Don't try to serve template that doesn't exist
- Add backtrace of error in logs

Author: jyn514

Cargo.lock

@@ -23,6 +23,7 @@ r2d2_postgres = "0.14"
 # url@2 for other usecases
 url = { version = "2.1.1", features = ["serde"] }
 badge = { path = "src/web/badge" }
+backtrace = "0.3"
 failure = "0.1.3"
 comrak = { version = "0.3", default-features = false }
 toml = "0.5"

Cargo.toml

@@ -11,10 +11,11 @@ macro_rules! ctry {
         match $result {
             Ok(v) => v,
             Err(e) => {
-                return $crate::web::page::Page::new(format!("{:?}", e))
-                    .title("An error has occured")
+                log::error!("{}\n{:?}", e, backtrace::Backtrace::new());
+                return $crate::web::page::Page::new(format!("{}", e))
+                    .title("Internal Server Error")
                     .set_status(::iron::status::BadRequest)
-                    .to_resp("resp");
+                    .to_resp("error");
             }
         }
     };
@@ -27,10 +28,14 @@ macro_rules! cexpect {
         match $option {
             Some(v) => v,
             None => {
-                return $crate::web::page::Page::new("Resource not found".to_owned())
-                    .title("An error has occured")
+                log::error!(
+                    "called cexpect!() on a `None` value\n{:?}",
+                    backtrace::Backtrace::new()
+                );
+                return $crate::web::page::Page::new("Internal Server Error".to_owned())
+                    .title("Internal Server Error")
                     .set_status(::iron::status::BadRequest)
-                    .to_resp("resp");
+                    .to_resp("error");
             }
         }
     };

src/web/mod.rs

@@ -1,2 +1,3 @@
 {{> header}}
+{{content}}
 {{> footer}}