Skip to content

Ungate tests that were skipped due to a broken implementation #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Ungate tests that were skipped due to a broken implementation #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions testcrate/src/bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,9 @@ pub fn skip_sys_checks(test_name: &str) -> bool {

/// Still run benchmarks/tests but don't check correctness between compiler-builtins and
/// assembly functions
pub fn skip_asm_checks(test_name: &str) -> bool {
// FIXME(f16_f128): rounding error
// <https://github.com/rust-lang/compiler-builtins/issues/616>
const SKIPPED: &[&str] = &["mul_f32", "mul_f64"];

SKIPPED.contains(&test_name)
pub fn skip_asm_checks(_test_name: &str) -> bool {
// Nothing to skip at this time
false
}

/// Create a comparison of the system symbol, compiler_builtins, and optionally handwritten
Expand Down
Loading