chore: Fallback to force clone on any error attempting repo reuse #6011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Make it so that, if we attempt to reuse the clone directory but run into some error, fall back to forcing the clone.
why
There are some subtle bugs when it comes to reusing the clone directory (example #6009, #6000). When I wrote the code (#5895) I was hoping it would be "good enough", but now I'm thinking that if something does go wrong, it's probably best to fallback to the known good path, and log an error.
tests
I added a unit test, and also ran this code on a branch before #6010 and watched it bypass the problem:
references
Addresses an issue in: #5895
Would have prevented: #6000, #6009