fix presigned urls + add very necessary test (#864)

Author: sourabhdesai

py/llama_cloud_services/files/client.py

@@ -35,6 +35,17 @@ async def get_file(self, file_id: str) -> File:
             file_id, project_id=self.project_id, organization_id=self.organization_id
         )
 
+    async def read_file_content(self, file_id: str) -> bytes:
+        presigned_url = await self.client.files.read_file_content(
+            file_id,
+            project_id=self.project_id,
+            organization_id=self.organization_id,
+        )
+        httpx_client = self.client._client_wrapper.httpx_client
+        response = await httpx_client.get(presigned_url.url)
+        response.raise_for_status()
+        return response.content
+
     async def upload_file(
         self, file_path: str, external_file_id: Optional[str] = None
     ) -> File:
@@ -67,7 +78,11 @@ async def upload_buffer(
                 ),
             )
             httpx_client = self.client._client_wrapper.httpx_client
-            await httpx_client.post(presigned_url.url, data=buffer)
+            upload_response = await httpx_client.put(
+                presigned_url.url,
+                data=buffer.read(),
+            )
+            upload_response.raise_for_status()
             return await self.client.files.get_file(
                 presigned_url.file_id,
                 project_id=self.project_id,

py/tests/test_files_client.py

@@ -130,3 +130,18 @@ async def test_upload_with_default_external_id(file_client: FileClient, test_fil
     assert isinstance(uploaded_file, File)
     assert uploaded_file.name == os.path.basename(test_file)
     assert uploaded_file.external_file_id == test_file
+
+
+@parametrize_use_presigned_url
+@pytest.mark.asyncio
+async def test_read_file_content(file_client: FileClient, test_file: str):
+    """Test reading a file content"""
+    # Upload a file first
+    external_file_id = f"test_read_file_content_{os.getpid()}"
+    uploaded_file = await file_client.upload_file(test_file, external_file_id)
+
+    # Read the file content
+    file_content = await file_client.read_file_content(uploaded_file.id)
+    with open(test_file, "rb") as f:
+        expected_file_content = f.read()
+    assert file_content == expected_file_content