Skip to content

Commit e5b0ab4

Browse files
authored
chore: fix aws sdk v2 (#5928)
1 parent 4e96935 commit e5b0ab4

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

.github/workflows/tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159
SNOWFLAKE_INTEGRATION_TEST_CREDENTIALS: ${{ secrets.SNOWFLAKE_INTEGRATION_TEST_CREDENTIALS }}
160160
SNOWFLAKE_RBAC_INTEGRATION_TEST_CREDENTIALS: ${{ secrets.SNOWFLAKE_RBAC_INTEGRATION_TEST_CREDENTIALS }}
161161
SNOWFLAKE_KEYPAIR_UNENCRYPTED_INTEGRATION_TEST_CREDENTIALS: ${{ secrets.SNOWFLAKE_KEYPAIR_UNENCRYPTED_INTEGRATION_TEST_CREDENTIALS }}
162-
RSERVER_FILE_MANAGER_USE_AWS_V2: "true"
162+
RSERVER_FILE_MANAGER_USE_AWS_SDK_V2: "true"
163163
- name: Upload coverage report
164164
uses: actions/upload-artifact@v4
165165
with:

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ require (
7979
github.com/rudderlabs/analytics-go v3.3.3+incompatible
8080
github.com/rudderlabs/bing-ads-go-sdk v0.2.3
8181
github.com/rudderlabs/compose-test v0.1.3
82-
github.com/rudderlabs/rudder-go-kit v0.52.0
82+
github.com/rudderlabs/rudder-go-kit v0.53.1
8383
github.com/rudderlabs/rudder-observability-kit v0.0.4
8484
github.com/rudderlabs/rudder-schemas v0.6.0
8585
github.com/rudderlabs/rudder-transformer/go v0.0.0-20250507094647-f18f2e217449

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1185,8 +1185,8 @@ github.com/rudderlabs/goqu/v10 v10.3.1 h1:rnfX+b4EwBWQ2UQfIGeEW299JBBkK5biEbnf7K
11851185
github.com/rudderlabs/goqu/v10 v10.3.1/go.mod h1:LH2vI5gGHBxEQuESqFyk5ZA2anGINc8o25hbidDWOYw=
11861186
github.com/rudderlabs/parquet-go v0.0.2 h1:ZXRdZdimB0PdJtmxeSSxfI0fDQ3kZjwzBxRi6Ut1J8k=
11871187
github.com/rudderlabs/parquet-go v0.0.2/go.mod h1:g6guum7o8uhj/uNhunnt7bw5Vabu/goI5i21/3fnxWQ=
1188-
github.com/rudderlabs/rudder-go-kit v0.52.0 h1:u2ygKrWDUcuIwjOFoecs6zW2cIc3OlR6DSG5H+AjlGs=
1189-
github.com/rudderlabs/rudder-go-kit v0.52.0/go.mod h1:5JzeZUBE6hBBXZ3KgtJwjrBuprxAXXDr8qnHVAbNVyM=
1188+
github.com/rudderlabs/rudder-go-kit v0.53.1 h1:u4m0aFlHo60/b+m+vymyCsh6VYqFJ78AfudnVWURAzU=
1189+
github.com/rudderlabs/rudder-go-kit v0.53.1/go.mod h1:5JzeZUBE6hBBXZ3KgtJwjrBuprxAXXDr8qnHVAbNVyM=
11901190
github.com/rudderlabs/rudder-observability-kit v0.0.4 h1:h9nLoWqiv/nqGOu1dhuVFAHNRkyodR6R3v36bqmavRs=
11911191
github.com/rudderlabs/rudder-observability-kit v0.0.4/go.mod h1:YTsvJmpvh8OLk7c4C+wXiV8NRdcrrdLa8UvIdLoXTho=
11921192
github.com/rudderlabs/rudder-schemas v0.6.0 h1:VL/TAGQGTaSlBhXt6DrBmM6kx2sF22QjUdsrlctGz+I=

warehouse/integrations/datalake/datalake_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ func TestIntegration(t *testing.T) {
7575
workspaceID := whutils.RandHex()
7676
jobsDBPort := c.Port("jobsDb", 5432)
7777
azEndPoint := fmt.Sprintf("localhost:%d", c.Port("azure", 10000))
78-
s3EndPoint := fmt.Sprintf("localhost:%d", c.Port("minio", 9000))
78+
s3EndPoint := fmt.Sprintf("http://localhost:%d", c.Port("minio", 9000))
79+
minioEndpoint := fmt.Sprintf("localhost:%d", c.Port("minio", 9000))
7980
gcsEndPoint := fmt.Sprintf("http://localhost:%d/storage/v1/", c.Port("gcs", 4443))
8081
transformerURL := fmt.Sprintf("http://localhost:%d", c.Port("transformer", 9090))
8182

@@ -113,7 +114,7 @@ func TestIntegration(t *testing.T) {
113114
batchStagingFiles: true,
114115
prerequisite: func(t testing.TB, ctx context.Context) {
115116
t.Helper()
116-
createMinioBucket(t, ctx, s3EndPoint, s3AccessKeyID, s3AccessKey, s3BucketName, s3Region)
117+
createMinioBucket(t, ctx, minioEndpoint, s3AccessKeyID, s3AccessKey, s3BucketName, s3Region)
117118
},
118119
configOverride: map[string]any{
119120
"region": s3Region,
@@ -442,12 +443,12 @@ func TestIntegration(t *testing.T) {
442443
c := testcompose.New(t, compose.FilePaths([]string{"../testdata/docker-compose.minio.yml"}))
443444
c.Start(context.Background())
444445

445-
s3EndPoint := fmt.Sprintf("localhost:%d", c.Port("minio", 9000))
446-
446+
s3EndPoint := fmt.Sprintf("http://localhost:%d", c.Port("minio", 9000))
447+
minioEndpoint := fmt.Sprintf("localhost:%d", c.Port("minio", 9000))
447448
ctx := context.Background()
448449
namespace := whth.RandSchema(whutils.S3Datalake)
449450

450-
createMinioBucket(t, ctx, s3EndPoint, s3AccessKeyID, s3AccessKey, s3BucketName, s3Region)
451+
createMinioBucket(t, ctx, minioEndpoint, s3AccessKeyID, s3AccessKey, s3BucketName, s3Region)
451452

452453
dest := backendconfig.DestinationT{
453454
ID: "test_destination_id",

0 commit comments

Comments
 (0)