Skip to content

Commit d60d224

Browse files
authored
fix: collected metric named router_process_jobs_count collides with previously collected histogram named router_process_jobs (#5966)
# Description A histogram's counter uses the _count suffix, thus renaming the histogram's name to avoid collision with the dedicated counter ## Security - [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.
1 parent ea1a527 commit d60d224

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

router/handle_lifecycle.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,9 @@ func (rt *Handle) Setup(
130130
rt.routerTransformInputCountStat = stats.Default.NewTaggedStat("router_transform_num_input_jobs", stats.CountType, statTags)
131131
rt.routerTransformOutputCountStat = stats.Default.NewTaggedStat("router_transform_num_output_jobs", stats.CountType, statTags)
132132
rt.batchInputOutputDiffCountStat = stats.Default.NewTaggedStat("router_batch_input_output_diff_jobs", stats.CountType, statTags)
133-
rt.processJobsHistogramStat = stats.Default.NewTaggedStat("router_process_jobs", stats.HistogramType, statTags)
133+
rt.processJobsHistogramStat = stats.Default.NewTaggedStat("router_process_jobs_hist", stats.HistogramType, statTags)
134134
rt.processJobsCountStat = stats.Default.NewTaggedStat("router_process_jobs_count", stats.CountType, statTags)
135-
rt.processRequestsHistogramStat = stats.Default.NewTaggedStat("router_process_requests", stats.HistogramType, statTags)
135+
rt.processRequestsHistogramStat = stats.Default.NewTaggedStat("router_process_requests_hist", stats.HistogramType, statTags)
136136
rt.processRequestsCountStat = stats.Default.NewTaggedStat("router_process_requests_count", stats.CountType, statTags)
137137
rt.routerResponseTransformStat = stats.Default.NewTaggedStat("response_transform_latency", stats.TimerType, statTags)
138138
rt.throttlingErrorStat = stats.Default.NewTaggedStat("router_throttling_error", stats.CountType, statTags)

0 commit comments

Comments
 (0)