Skip to content

Commit cb67451

Browse files
author
Kenji Miyake
committed
Improve readability
Signed-off-by: Kenji Miyake <[email protected]>
1 parent 88e894b commit cb67451

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

launch_ros/launch_ros/actions/composable_node_container.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,11 @@ def parse(cls, entity: Entity, parser: Parser):
6363
composable_nodes = entity.get_attr(
6464
'composable_node', data_type=List[Entity], optional=True)
6565
if composable_nodes is not None:
66-
parsed_tuples = [ComposableNode.parse(parser, entity) for entity in composable_nodes]
67-
kwargs['composable_node_descriptions'] = [t[0](**t[1]) for t in parsed_tuples]
66+
kwargs['composable_node_descriptions'] = []
67+
for entity in composable_nodes:
68+
_, composable_node_kwargs = ComposableNode.parse(parser, entity)
69+
kwargs['composable_node_descriptions'].append(
70+
ComposableNode(**composable_node_kwargs))
6871

6972
return cls, kwargs
7073

launch_ros/launch_ros/actions/load_composable_nodes.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,11 @@ def parse(cls, entity: Entity, parser: Parser):
9595
entity.get_attr('target', data_type=str))
9696

9797
composable_nodes = entity.get_attr('composable_node', data_type=List[Entity])
98-
if composable_nodes is not None:
99-
parsed_tuples = [ComposableNode.parse(parser, entity) for entity in composable_nodes]
100-
kwargs['composable_node_descriptions'] = [t[0](**t[1]) for t in parsed_tuples]
98+
kwargs['composable_node_descriptions'] = []
99+
for entity in composable_nodes:
100+
_, composable_node_kwargs = ComposableNode.parse(parser, entity)
101+
kwargs['composable_node_descriptions'].append(
102+
ComposableNode(**composable_node_kwargs))
101103

102104
return cls, kwargs
103105

0 commit comments

Comments
 (0)