Skip to content

Commit 0caf2d7

Browse files
committed
fixing tests
1 parent 1f68433 commit 0caf2d7

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed
Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,33 @@
11
from unittest.mock import patch
22
from holmes.config import Config
33

4+
ROBUSTA_MODEL_NAME = "Robusta/gpt-4o"
5+
46

57
@patch("holmes.config.ROBUSTA_AI", True)
68
def test_cli_not_loading_robusta_ai(monkeypatch):
79
config = Config.load_from_file(None)
8-
assert "Robusta" not in config._model_list
10+
assert ROBUSTA_MODEL_NAME not in config._model_list
911

1012

1113
@patch("holmes.config.ROBUSTA_AI", True)
1214
def test_server_loads_robusta_ai_when_true(monkeypatch):
1315
config = Config.load_from_env()
14-
assert "Robusta" in config._model_list
16+
assert ROBUSTA_MODEL_NAME in config._model_list
1517

1618

1719
@patch("holmes.config.ROBUSTA_AI", None)
1820
def test_server_loads_robusta_ai_when_not_exists_and_not_other_models(monkeypatch):
1921
config = Config.load_from_env()
2022
assert len(config._model_list) == 1
21-
assert "Robusta" in config._model_list
23+
assert ROBUSTA_MODEL_NAME in config._model_list
2224

2325

2426
@patch("holmes.config.ROBUSTA_AI", False)
2527
def test_server_not_loads_robusta_ai_when_false(monkeypatch):
2628
config = Config.load_from_env()
2729
assert len(config._model_list) == 0
28-
assert "Robusta" not in config._model_list
30+
assert ROBUSTA_MODEL_NAME not in config._model_list
2931

3032

3133
@patch("holmes.config.ROBUSTA_AI", True)
@@ -36,7 +38,7 @@ def test_server_not_loads_robusta_ai_when_false(monkeypatch):
3638
def test_server_loads_robusta_ai_when_true_and_model_list_exists(monkeypatch):
3739
config = Config.load_from_env()
3840
assert "existing_model" in config._model_list
39-
assert "Robusta" in config._model_list
41+
assert ROBUSTA_MODEL_NAME in config._model_list
4042

4143

4244
@patch("holmes.config.ROBUSTA_AI", False)
@@ -47,7 +49,7 @@ def test_server_loads_robusta_ai_when_true_and_model_list_exists(monkeypatch):
4749
def test_server_not_loads_robusta_ai_when_false_and_model_list_exists(monkeypatch):
4850
config = Config.load_from_env()
4951
assert "existing_model" in config._model_list
50-
assert "Robusta" not in config._model_list
52+
assert ROBUSTA_MODEL_NAME not in config._model_list
5153

5254

5355
@patch("holmes.config.ROBUSTA_AI", None)
@@ -58,21 +60,21 @@ def test_server_not_loads_robusta_ai_when_false_and_model_list_exists(monkeypatc
5860
def test_server_not_loads_robusta_ai_when_no_env_var_and_model_list_exists(monkeypatch):
5961
config = Config.load_from_env()
6062
assert "existing_model" in config._model_list
61-
assert "Robusta" not in config._model_list
63+
assert ROBUSTA_MODEL_NAME not in config._model_list
6264

6365

6466
@patch("holmes.config.ROBUSTA_AI", True)
6567
def test_server_loads_robusta_ai_when_model_var_exists(monkeypatch):
6668
monkeypatch.setenv("MODEL", "some_model")
6769
config = Config.load_from_env()
68-
assert "Robusta" in config._model_list
70+
assert ROBUSTA_MODEL_NAME in config._model_list
6971

7072

7173
@patch("holmes.config.ROBUSTA_AI", None)
7274
def test_server_not_loads_robusta_ai_when_model_var_exists_and_no_env_var(monkeypatch):
7375
monkeypatch.setenv("MODEL", "some_model")
7476
config = Config.load_from_env()
75-
assert "Robusta" not in config._model_list
77+
assert ROBUSTA_MODEL_NAME not in config._model_list
7678

7779

7880
@patch("holmes.config.ROBUSTA_AI", False)
@@ -81,4 +83,4 @@ def test_server_not_loads_robusta_ai_when_model_var_exists_and_false_env_var(
8183
):
8284
monkeypatch.setenv("MODEL", "some_model")
8385
config = Config.load_from_env()
84-
assert "Robusta" not in config._model_list
86+
assert ROBUSTA_MODEL_NAME not in config._model_list

0 commit comments

Comments
 (0)