fusefrontend: unregister from openfiletable before closing the fd

rfjakob · rfjakob · commit 00af4f48643f · 2019-10-06T21:47:36.000+02:00
Closing the fd means the inode number may be reused immediately by a new file, so we have to get the old fileID out of the table beforehand! Hopefully fixes #363
diff --git a/internal/fusefrontend/file.go b/internal/fusefrontend/file.go
@@ -401,11 +401,10 @@ func (f *File) Release() {
 	if f.released {
 		log.Panicf("ino%d fh%d: double release", f.qIno.Ino, f.intFd())
 	}
-	f.fd.Close()
 	f.released = true
-	f.fdLock.Unlock()
-
 	openfiletable.Unregister(f.qIno)
+	f.fd.Close()
+	f.fdLock.Unlock()
 }
 
 // Flush - FUSE call

Original file line number	Diff line number	Diff line change
`@@ -401,11 +401,10 @@ func (f *File) Release() {`
`401`	`401`	`if f.released {`
`402`	`402`	`log.Panicf("ino%d fh%d: double release", f.qIno.Ino, f.intFd())`
`403`	`403`	`}`
`404`		`- f.fd.Close()`
`405`	`404`	`f.released = true`
`406`		`- f.fdLock.Unlock()`
`407`		`-`
`408`	`405`	`openfiletable.Unregister(f.qIno)`
	`406`	`+ f.fd.Close()`
	`407`	`+ f.fdLock.Unlock()`
`409`	`408`	`}`
`410`	`409`
`411`	`410`	`// Flush - FUSE call`