Skip to content

Commit 22f96e3

Browse files
authored
Merge pull request #69 from reviewdog/add_fail_level
Add fail_level and deduplicate fail_on_error
2 parents ccaafec + e48fb59 commit 22f96e3

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,16 @@ github-pr-review can use Markdown and add a link to rule page in reviewdog repor
3535
Optional. Filtering mode for the reviewdog command [added,diff_context,file,nofilter].
3636
Default is `file`.
3737

38+
### `fail_level`
39+
40+
Optional. If set to `none`, always use exit code 0 for reviewdog.
41+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
42+
Possible values: [`none`, `any`, `info`, `warning`, `error`]
43+
Default is `none`.
44+
3845
### `fail_on_error`
3946

47+
Deprecated, use `fail_level` instead.
4048
Optional. Exit code for reviewdog when errors are found [true,false]
4149
Default is `false`.
4250

action.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,19 @@ inputs:
2323
Default is `file`.
2424
default: 'file'
2525
required: false
26+
fail_level:
27+
description: |
28+
If set to `none`, always use exit code 0 for reviewdog.
29+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
30+
Possible values: [none,any,info,warning,error]
31+
Default is `none`.
32+
default: 'none'
2633
fail_on_error:
2734
description: |
35+
Deprecated, use `fail_level` instead.
2836
Exit code for reviewdog when errors are found [true,false]
2937
Default is `false`.
38+
deprecationMessage: Deprecated, use `fail_level` instead.
3039
default: 'false'
3140
required: false
3241
reviewdog_flags:
@@ -71,6 +80,7 @@ runs:
7180
INPUT_LEVEL: ${{ inputs.level }}
7281
INPUT_REPORTER: ${{ inputs.reporter }}
7382
INPUT_FILTER_MODE: ${{ inputs.filter_mode }}
83+
INPUT_FAIL_LEVEL: ${{ inputs.fail_level }}
7484
INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }}
7585
INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }}
7686
INPUT_PATH: ${{ inputs.path }}

script.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ if [ "${INPUT_REPORTER}" = 'github-pr-review' ]; then
7575
-name="shellcheck" \
7676
-reporter=github-pr-review \
7777
-filter-mode="${INPUT_FILTER_MODE}" \
78+
-fail-level="${INPUT_FAIL_LEVEL}" \
7879
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
7980
-level="${INPUT_LEVEL}" \
8081
${INPUT_REVIEWDOG_FLAGS}
@@ -88,6 +89,7 @@ else
8889
-name="shellcheck" \
8990
-reporter="${INPUT_REPORTER:-github-pr-check}" \
9091
-filter-mode="${INPUT_FILTER_MODE}" \
92+
-fail-level="${INPUT_FAIL_LEVEL}" \
9193
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
9294
-level="${INPUT_LEVEL}" \
9395
${INPUT_REVIEWDOG_FLAGS}
@@ -105,6 +107,7 @@ shellcheck -f diff ${FILES} \
105107
-f.diff.strip=1 \
106108
-reporter="github-pr-review" \
107109
-filter-mode="${INPUT_FILTER_MODE}" \
110+
-fail-level="${INPUT_FAIL_LEVEL}" \
108111
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
109112
${INPUT_REVIEWDOG_FLAGS}
110113
EXIT_CODE_SUGGESTION=$?

0 commit comments

Comments
 (0)