Skip to content

Commit 5e2218f

Browse files
authored
Add Setup Logging (#2018)
* Explicitly log the following setup states: 1. Starting 2. Started 3. Succeeded 4. Failed * This gives us better visibility into how long each of these setup pieces takes.
1 parent 5c1908f commit 5e2218f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

python/cog/server/runner.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
from urllib3.util.retry import Retry
1414

1515
from .. import schema
16+
from ..base_input import BaseInput
1617
from ..files import put_file_to_signed_endpoint
1718
from ..json import upload_files
18-
from ..predictor import BaseInput
1919
from ..types import PYDANTIC_V2
2020
from .errors import FileUploadError, RunnerBusyError, UnknownPredictionError
2121
from .eventtypes import Done, Log, PredictionOutput, PredictionOutputType
@@ -163,6 +163,7 @@ def result(self) -> T:
163163

164164
class SetupTask(Task[SetupResult]):
165165
def __init__(self, _clock: Optional[Callable[[], datetime]] = None) -> None:
166+
log.info("starting setup")
166167
self._clock = _clock
167168
if self._clock is None:
168169
self._clock = lambda: datetime.now(timezone.utc)
@@ -175,6 +176,7 @@ def result(self) -> SetupResult:
175176
return self._result
176177

177178
def track(self, fut: "Future[Done]") -> None:
179+
log.info("started setup")
178180
self._fut = fut
179181
self._fut.add_done_callback(self._handle_done)
180182

@@ -194,11 +196,13 @@ def append_logs(self, message: str) -> None:
194196
self._result.logs.append(message)
195197

196198
def succeeded(self) -> None:
199+
log.info("setup succeeded")
197200
assert self._clock
198201
self._result.completed_at = self._clock()
199202
self._result.status = schema.Status.SUCCEEDED
200203

201204
def failed(self) -> None:
205+
log.info("setup failed")
202206
assert self._clock
203207
self._result.completed_at = self._clock()
204208
self._result.status = schema.Status.FAILED

0 commit comments

Comments
 (0)