remove leftover fields && duplicate comparison

Signed-off-by: Atif Ali <[email protected]>

Author: aali309

controllers/consoleplugin.go

@@ -55,12 +55,10 @@ func getPluginPodSpec() corev1.PodSpec {
 	podSpec := corev1.PodSpec{
 		Containers: []corev1.Container{
 			{
-				Env:                      util.ProxyEnvVars(),
-				Name:                     gitopsPluginName,
-				Image:                    consolePluginImage,
-				ImagePullPolicy:          corev1.PullAlways,
-				TerminationMessagePath:   corev1.TerminationMessagePathDefault,
-				TerminationMessagePolicy: corev1.TerminationMessageReadFile,
+				Env:             util.ProxyEnvVars(),
+				Name:            gitopsPluginName,
+				Image:           consolePluginImage,
+				ImagePullPolicy: corev1.PullAlways,
 				Ports: []corev1.ContainerPort{
 					{
 						Name:          "http",

controllers/gitopsservice_controller.go

@@ -670,15 +670,11 @@ func (r *ReconcileGitopsService) reconcileBackend(gitopsserviceNamespacedName ty
 				found.Spec.Template.Spec.Containers[0].Env = deploymentObj.Spec.Template.Spec.Containers[0].Env
 				changed = true
 			}
-			// Use semantic equality to handle Kubernetes defaults properly
-			if !equality.Semantic.DeepEqual(found.Spec.Template.Spec.Containers[0].Resources, deploymentObj.Spec.Template.Spec.Containers[0].Resources) {
-				found.Spec.Template.Spec.Containers[0].Resources = deploymentObj.Spec.Template.Spec.Containers[0].Resources
-				changed = true
-			}
 			if !equality.Semantic.DeepEqual(found.Spec.Template.Spec.Containers[0].Args, deploymentObj.Spec.Template.Spec.Containers[0].Args) {
 				found.Spec.Template.Spec.Containers[0].Args = deploymentObj.Spec.Template.Spec.Containers[0].Args
 				changed = true
 			}
+			// Use semantic equality to handle Kubernetes defaults properly
 			if !equality.Semantic.DeepEqual(found.Spec.Template.Spec.Containers[0].Resources, deploymentObj.Spec.Template.Spec.Containers[0].Resources) {
 				found.Spec.Template.Spec.Containers[0].Resources = deploymentObj.Spec.Template.Spec.Containers[0].Resources
 				changed = true