[Php85] Rename deprecated SplObjectStorage methods #7123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Aug 9, 2025
| $rectorConfig->ruleWithConfiguration( | ||
| RenameMethodRector::class, | ||
| [ | ||
| new MethodCallRename('SplObjectStorage', 'contains', 'offsetExists'), |
Member
There was a problem hiding this comment.
The PHP documentation seems ambiguous 😃 , it says:
SplObjectStorage::offsetExists() is an alias of [SplObjectStorage::contains()](https://www.php.net/manual/en/splobjectstorage.contains.php).
https://www.php.net/manual/en/splobjectstorage.offsetexists.php
Contributor
Author
There was a problem hiding this comment.
Interesting. But I would guess this to be an issue in the documentation or previously the "alias relationship" was seen in the opposite direction. But the RFC is clear in stating to use the existing methods inherited from ArrayAccess instead of the custom ones from SplObjectStorage .
Member
There was a problem hiding this comment.
yes, indeed, looks like documentation issue.
samsonasik
approved these changes
Aug 9, 2025
Member
|
Thank you @mttsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.