Skip to content

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 6, 2025

@VincentLanglet VincentLanglet requested a review from samsonasik July 6, 2025 15:31
@VincentLanglet VincentLanglet requested a review from samsonasik July 6, 2025 18:08
@samsonasik
Copy link
Member

Could you register to CodeQualityLevel class, probably on the last after:

StaticToSelfStaticMethodCallOnFinalClassRector::class,

then, try execute:

bin/rector

to ensure it works on rector-src codebase.

@VincentLanglet
Copy link
Contributor Author

then, try execute:

bin/rector

to ensure it works on rector-src codebase.

Ins't checked by the CI ? I didn't succeed installing the project because of composer patches...

@samsonasik
Copy link
Member

samsonasik commented Jul 6, 2025

@VincentLanglet that only when you have write access to repo,

You may need to install + configure gpatch, see troubleshooting note:

https://github.com/symplify/vendor-patches?tab=readme-ov-file#troubleshooting

@VincentLanglet
Copy link
Contributor Author

You may need to install + configure gpatch, see troubleshooting note:

symplify/vendor-patches#troubleshooting

Thanks ! It works well.

I added a commit with the rector run

@TomasVotruba TomasVotruba requested a review from samsonasik July 6, 2025 19:37
@samsonasik
Copy link
Member

Thank you @VincentLanglet

@samsonasik samsonasik enabled auto-merge (squash) July 7, 2025 04:36
@samsonasik samsonasik merged commit 7e9cf47 into rectorphp:main Jul 7, 2025
46 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule to sort NamedParam usage based on function definition

2 participants