[Php80] Prevent adding empty return when stringable always throws #6968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You can use TerminatedNodeAnalyzer for that, see usage exanple on On your use case, stmtsaware is class method, previous stmt is the Expression of Throw, and stmt is the return stmt. Actually, if you combine with deadCode set, this already skipped as removed already, see https://getrector.com/demo/e87c6d53-312b-4044-a46f-0007c65b06dc |
Contributor
Author
|
TerminatedNodeAnalyzer made it look much cleaner |
Member
|
Thank you @Mika- 👍 |
samsonasik
reviewed
Jun 10, 2025
| private const ALLOWED_CONTINUE_CURRENT_STMTS = [InlineHTML::class, Nop::class]; | ||
|
|
||
| public function isAlwaysTerminated(StmtsAwareInterface $stmtsAware, Stmt $node, Stmt $currentStmt): bool | ||
| public function isAlwaysTerminated(StmtsAwareInterface|ClassMethod $stmtsAware, Stmt $node, Stmt $currentStmt): bool |
Member
There was a problem hiding this comment.
This change is not needed, ClassMethod is already instanceof StmtsAwareInterface
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents adding empty return when stringable always throws. Not sure if this is the right way to fix this.
https://getrector.com/demo/c4c2d42d-16f0-454d-af48-da9f06f84bf6