skip behats (#451)

Author: TomasVotruba

rules-tests/TypedCollections/Rector/If_/RemoveIfInstanceofCollectionRector/Fixture/skip_behat_context.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\If_\RemoveIfInstanceofCollectionRector\Fixture;
+
+use Behat\Behat\Context\Context;
+
+final class SkipBehatContext implements Context
+{
+    public function letItBe(?\Doctrine\Common\Collections\Collection $collection)
+    {
+        if (! $collection instanceof \Doctrine\Common\Collections\Collection) {
+            throw new \InvalidArgumentException();
+        }
+    }
+}

rules/TypedCollections/Rector/If_/RemoveIfInstanceofCollectionRector.php

@@ -17,8 +17,11 @@
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Stmt\If_;
 use PhpParser\NodeVisitorAbstract;
+use PHPStan\Reflection\ClassReflection;
+use Rector\Doctrine\Enum\TestClass;
 use Rector\Doctrine\TypedCollections\TypeAnalyzer\CollectionTypeDetector;
 use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -48,8 +51,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node)
     {
-        // most likely on purpose in tests
-        if ($this->testsNodeAnalyzer->isInTestClass($node)) {
+        if ($this->shouldSkip($node)) {
             return null;
         }
 
@@ -223,4 +225,22 @@ private function isIsObjectFuncCallOnCollection(Expr $expr): bool
 
         return $this->collectionTypeDetector->isCollectionType($firstArg->value);
     }
+
+    private function shouldSkip(If_|Node|Coalesce|Ternary|BooleanNot|BooleanAnd $node): bool
+    {
+        // most likely on purpose in tests
+        if ($this->testsNodeAnalyzer->isInTestClass($node)) {
+            return true;
+        }
+
+        $classScope = ScopeFetcher::fetch($node);
+        $classReflection = $classScope->getClassReflection();
+
+        if (! $classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        // usually assert on purpose
+        return $classReflection->is(TestClass::BEHAT_CONTEXT);
+    }
 }

stubs/Behat/Behat/Context/Context.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Behat\Behat\Context;
+
+interface Context
+{
+}