Handle errors during buffering

Author: andig

src/Middleware/RequestBodyBufferMiddleware.php

@@ -53,7 +53,7 @@ public function __invoke(ServerRequestInterface $request, $stack)
                 return new Response(413, array('Content-Type' => 'text/plain'), 'Request body exceeds allowed limit');
             }
 
-            return $error;
+            throw $error;
         });
     }
 

tests/Middleware/RequestBodyBufferMiddlewareTest.php

@@ -123,4 +123,32 @@ function($response) use (&$exposedResponse) {
 
         Block\await($promise, $loop);
     }
+
+    /**
+     * @expectedException RuntimeException
+     */
+    public function testBufferingErrorThrows()
+    {
+        $loop = Factory::create();
+        
+        $stream = new ThroughStream();
+        $serverRequest = new ServerRequest(
+            'GET',
+            'https://example.com/',
+            array(),
+            new HttpBodyStream($stream, null)
+        );
+
+        $buffer = new RequestBodyBufferMiddleware(1);
+        $promise = $buffer(
+            $serverRequest,
+            function (ServerRequestInterface $request) {
+                return $request;
+            }
+        );
+
+        $stream->emit('error', array(new \RuntimeException()));
+
+        Block\await($promise, $loop);
+    }
 }