Test removing both readable and writable side of stream when closing

Author: clue

tests/AbstractLoopTest.php

@@ -184,6 +184,78 @@ public function testRemoveStreamForWriteOnly()
         $this->tickLoop($this->loop);
     }
 
+    public function testRemoveReadAndWriteStreamFromLoopOnceResourceClosesEndsLoop()
+    {
+        list($stream, $other) = $this->createSocketPair();
+        stream_set_blocking($stream, false);
+        stream_set_blocking($other, false);
+
+        // dummy writable handler
+        $this->loop->addWriteStream($stream, function () { });
+
+        // remove stream when the stream is readable (closes)
+        $this->loop->addReadStream($stream, function ($stream) {
+            $this->loop->removeReadStream($stream);
+            $this->loop->removeWriteStream($stream);
+            fclose($stream);
+        });
+
+        // close other side
+        fclose($other);
+
+        $this->assertRunFasterThan($this->tickTimeout);
+    }
+
+    public function testRemoveReadAndWriteStreamFromLoopOnceResourceClosesOnEndOfFileEndsLoop()
+    {
+        list($stream, $other) = $this->createSocketPair();
+        stream_set_blocking($stream, false);
+        stream_set_blocking($other, false);
+
+        // dummy writable handler to fill outgoing buffer
+        $this->loop->addWriteStream($stream, function ($stream) use ($other) {
+            fwrite($stream, str_repeat('.', 60000));
+
+            // close other side once outgoing buffer is filled
+            fclose($other);
+        });
+
+        // remove stream when the stream is readable (closes)
+        $never = $this->expectCallableNever();
+        $this->loop->addReadStream($stream, function ($stream) use ($never) {
+            $data = fread($stream, 1024);
+            if ($data !== '') {
+                // we expect to read an empty string => stream closed
+                return $never();
+            }
+
+            $this->loop->removeReadStream($stream);
+            $this->loop->removeWriteStream($stream);
+            fclose($stream);
+        });
+
+        $this->assertRunFasterThan(0.1);
+    }
+
+    public function testRemoveReadAndWriteStreamFromLoopWithClosingResourceEndsLoop()
+    {
+        // get only one part of the pair to ensure the other side will close immediately
+        list($stream) = $this->createSocketPair();
+        stream_set_blocking($stream, false);
+
+        // dummy writable handler
+        $this->loop->addWriteStream($stream, function () { });
+
+        // remove stream when the stream is readable (closes)
+        $this->loop->addReadStream($stream, function ($stream) {
+            $this->loop->removeReadStream($stream);
+            $this->loop->removeWriteStream($stream);
+            fclose($stream);
+        });
+
+        $this->assertRunFasterThan($this->tickTimeout);
+    }
+
     public function testRemoveInvalid()
     {
         list ($stream) = $this->createSocketPair();