fix(iOS): fix 'secure' and 'httpOnly' values always being false (#126)

abendi · web-flow · commit 354e9bbdbcf8 · 2021-08-26T14:45:35.000-07:00
diff --git a/ios/RNCookieManagerIOS/RNCookieManagerIOS.m b/ios/RNCookieManagerIOS/RNCookieManagerIOS.m
@@ -313,11 +313,11 @@ -(NSHTTPCookie *)makeHTTPCookieObject:(NSURL *)url
     if (!isEmpty(expires)) {
          [cookieProperties setObject:expires forKey:NSHTTPCookieExpires];
     }
-    if (!isEmpty(secure)) {
-        [cookieProperties setObject:secure forKey:@"secure"];
+    if ([secure boolValue]) {
+        [cookieProperties setObject:secure forKey:NSHTTPCookieSecure];
     }
-    if (!isEmpty(httpOnly)) {
-        [cookieProperties setObject:httpOnly forKey:@"HTTPOnly"];
+    if ([httpOnly boolValue]) {
+        [cookieProperties setObject:httpOnly forKey:@"HttpOnly"];
     }
 
     NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];

Original file line number	Diff line number	Diff line change
`@@ -313,11 +313,11 @@ -(NSHTTPCookie )makeHTTPCookieObject:(NSURL )url`
`313`	`313`	`if (!isEmpty(expires)) {`
`314`	`314`	`[cookieProperties setObject:expires forKey:NSHTTPCookieExpires];`
`315`	`315`	`}`
`316`		`- if (!isEmpty(secure)) {`
`317`		`- [cookieProperties setObject:secure forKey:@"secure"];`
	`316`	`+ if ([secure boolValue]) {`
	`317`	`+ [cookieProperties setObject:secure forKey:NSHTTPCookieSecure];`
`318`	`318`	`}`
`319`		`- if (!isEmpty(httpOnly)) {`
`320`		`- [cookieProperties setObject:httpOnly forKey:@"HTTPOnly"];`
	`319`	`+ if ([httpOnly boolValue]) {`
	`320`	`+ [cookieProperties setObject:httpOnly forKey:@"HttpOnly"];`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];`