Skip to content

Commit 630f631

Browse files
authored
Prevent default for links to avoid double click events (#812)
1 parent 60f2f24 commit 630f631

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/menu-button/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,10 +662,10 @@ const MenuItems = React.forwardRef(function MenuItems(
662662
// consistent behavior across menu items we'll trigger a click when
663663
// the spacebar is pressed.
664664
if (selected) {
665+
event.preventDefault();
665666
if (selected.isLink && selected.element) {
666667
selected.element.click();
667668
} else {
668-
event.preventDefault();
669669
// Focus the button first by default when an item is selected.
670670
// We fire the onSelect callback next so the app can manage
671671
// focus if needed.

0 commit comments

Comments
 (0)