You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Why are these changes needed?
The
[_get_live_deployments](https://github.com/ray-project/ray/blob/master/python/ray/serve/_private/application_state.py#L476)
function internally calls
[get_deployments_in_application](https://github.com/ray-project/ray/blob/master/python/ray/serve/_private/deployment_state.py#L2603)
that iterates over self._deployment_state ( that stores all the live
deployments) and filters out deployment for a specific app. This is
inefficient especially when you have a large of serve application
running. (For every serve application we are iterating over all the
deployments)
## Related issue number
Closes#45793
## Checks
- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
- [ ] Unit tests
- [ ] Release tests
- [x] This PR is not tested :(
---------
Signed-off-by: Jugal Shah <[email protected]>
Co-authored-by: Jugal Shah <[email protected]>
0 commit comments