Skip to content

Commit bc13a01

Browse files
edoakeselliot-barn
authored andcommitted
[core] Remove deprecated ray start CLI options (#53675)
These have been deprecated/ignored for a long time and are polluting the help string. --------- Signed-off-by: Edward Oakes <[email protected]> Signed-off-by: elliot-barn <[email protected]>
1 parent f643f2a commit bc13a01

File tree

1 file changed

+0
-54
lines changed

1 file changed

+0
-54
lines changed

python/ray/scripts/scripts.py

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -397,12 +397,6 @@ def debug(address: str, verbose: bool):
397397
default=0,
398398
help="the port to use for starting the node manager",
399399
)
400-
@click.option(
401-
"--gcs-server-port",
402-
required=False,
403-
type=int,
404-
help="Port number for the GCS server.",
405-
)
406400
@click.option(
407401
"--min-worker-port",
408402
required=False,
@@ -519,12 +513,6 @@ def debug(address: str, verbose: bool):
519513
default=None,
520514
help="the port for dashboard agents to listen for grpc on.",
521515
)
522-
@click.option(
523-
"--dashboard-grpc-port",
524-
type=int,
525-
default=None,
526-
help="(Deprecated) No longer used and will be removed in a future version of Ray.",
527-
)
528516
@click.option(
529517
"--runtime-env-agent-port",
530518
type=int,
@@ -561,16 +549,6 @@ def debug(address: str, verbose: bool):
561549
default=False,
562550
help="do not redirect non-worker stdout and stderr to files",
563551
)
564-
@click.option(
565-
"--plasma-store-socket-name",
566-
default=None,
567-
help="manually specify the socket name of the plasma store",
568-
)
569-
@click.option(
570-
"--raylet-socket-name",
571-
default=None,
572-
help="manually specify the socket path of the raylet process",
573-
)
574552
@click.option(
575553
"--temp-dir",
576554
default=None,
@@ -713,7 +691,6 @@ def start(
713691
redis_shard_ports,
714692
object_manager_port,
715693
node_manager_port,
716-
gcs_server_port,
717694
min_worker_port,
718695
max_worker_port,
719696
worker_port_list,
@@ -728,16 +705,13 @@ def start(
728705
dashboard_host,
729706
dashboard_port,
730707
dashboard_agent_listen_port,
731-
dashboard_grpc_port,
732708
dashboard_agent_grpc_port,
733709
runtime_env_agent_port,
734710
block,
735711
plasma_directory,
736712
object_spilling_directory,
737713
autoscaling_config,
738714
no_redirect_output,
739-
plasma_store_socket_name,
740-
raylet_socket_name,
741715
temp_dir,
742716
storage,
743717
system_config,
@@ -757,13 +731,6 @@ def start(
757731
):
758732
"""Start Ray processes manually on the local machine."""
759733

760-
if gcs_server_port is not None:
761-
cli_logger.error(
762-
"`{}` is deprecated and ignored. Use {} to specify "
763-
"GCS server port on head node.",
764-
cf.bold("--gcs-server-port"),
765-
cf.bold("--port"),
766-
)
767734
# Whether the original arguments include node_ip_address.
768735
include_node_ip_address = False
769736
if node_ip_address is not None:
@@ -807,21 +774,6 @@ def start(
807774
cf.bold('--labels="key1=val1,key2=val2"'),
808775
)
809776
labels_dict = {**labels_from_file, **labels_from_string}
810-
811-
if plasma_store_socket_name is not None:
812-
warnings.warn(
813-
"plasma_store_socket_name is deprecated and will be removed. You are not "
814-
"supposed to specify this parameter as it's internal.",
815-
DeprecationWarning,
816-
stacklevel=2,
817-
)
818-
if raylet_socket_name is not None:
819-
warnings.warn(
820-
"raylet_socket_name is deprecated and will be removed. You are not "
821-
"supposed to specify this parameter as it's internal.",
822-
DeprecationWarning,
823-
stacklevel=2,
824-
)
825777
if temp_dir and not head:
826778
cli_logger.warning(
827779
f"`--temp-dir={temp_dir}` option will be ignored. "
@@ -853,10 +805,6 @@ def start(
853805
"--storage is deprecated and will be removed in a future version of Ray.",
854806
)
855807

856-
if dashboard_grpc_port is not None:
857-
warnings.warn(
858-
"--dashboard-grpc-port is deprecated and will be removed in a future version of Ray.",
859-
)
860808
ray_params = ray._private.parameter.RayParams(
861809
node_ip_address=node_ip_address,
862810
node_name=node_name if node_name else node_ip_address,
@@ -879,8 +827,6 @@ def start(
879827
plasma_directory=plasma_directory,
880828
object_spilling_directory=object_spilling_directory,
881829
huge_pages=False,
882-
plasma_store_socket_name=plasma_store_socket_name,
883-
raylet_socket_name=raylet_socket_name,
884830
temp_dir=temp_dir,
885831
storage=storage,
886832
include_dashboard=include_dashboard,

0 commit comments

Comments
 (0)