[core] Move on HandleAddTaskEventData (#52904)

Signed-off-by: dayshah <[email protected]>

Author: dayshah

src/ray/gcs/gcs_server/gcs_task_manager.cc

@@ -34,7 +34,6 @@ namespace gcs {
 
 GcsTaskManager::GcsTaskManager(instrumented_io_context &io_service)
     : io_service_(io_service),
-      stats_counter_(),
       task_event_storage_(std::make_unique<GcsTaskManagerStorage>(
           RayConfig::instance().task_events_max_num_task_in_gcs(),
           stats_counter_,
@@ -381,6 +380,8 @@ void GcsTaskManager::GcsTaskManagerStorage::AddOrReplaceTaskEvent(
   }
 }
 
+namespace {
+
 template <typename T>
 bool apply_predicate(const T &lhs, rpc::FilterPredicate predicate, const T &rhs) {
   switch (predicate) {
@@ -412,6 +413,8 @@ bool apply_predicate_ignore_case(std::string_view lhs,
   }
 }
 
+}  // namespace
+
 void GcsTaskManager::HandleGetTaskEvents(rpc::GetTaskEventsRequest request,
                                          rpc::GetTaskEventsReply *reply,
                                          rpc::SendReplyCallback send_reply_callback) {
@@ -607,7 +610,6 @@ void GcsTaskManager::HandleGetTaskEvents(rpc::GetTaskEventsRequest request,
   }
 
   GCS_RPC_SEND_REPLY(send_reply_callback, reply, status);
-  return;
 }
 
 void GcsTaskManager::GcsTaskManagerStorage::RecordDataLossFromWorker(
@@ -639,7 +641,7 @@ void GcsTaskManager::GcsTaskManagerStorage::RecordDataLossFromWorker(
 void GcsTaskManager::HandleAddTaskEventData(rpc::AddTaskEventDataRequest request,
                                             rpc::AddTaskEventDataReply *reply,
                                             rpc::SendReplyCallback send_reply_callback) {
-  auto data = std::move(request.data());
+  auto data = std::move(*request.mutable_data());
   task_event_storage_->RecordDataLossFromWorker(data);
 
   for (auto events_by_task : *data.mutable_events_by_task()) {
@@ -683,7 +685,7 @@ void GcsTaskManager::RecordMetrics() {
 
   {
     absl::MutexLock lock(&mutex_);
-    if (usage_stats_client_) {
+    if (usage_stats_client_ != nullptr) {
       usage_stats_client_->RecordExtraUsageCounter(
           usage::TagKey::NUM_ACTOR_CREATION_TASKS, counters[kTotalNumActorCreationTask]);
       usage_stats_client_->RecordExtraUsageCounter(usage::TagKey::NUM_ACTOR_TASKS,

src/ray/gcs/gcs_server/gcs_task_manager.h

@@ -67,9 +67,9 @@ class TaskEventsGcPolicyInterface {
 
 class FinishedTaskActorTaskGcPolicy : public TaskEventsGcPolicyInterface {
  public:
-  size_t MaxPriority() const { return 3; }
+  size_t MaxPriority() const override { return 3; }
 
-  size_t GetTaskListPriority(const rpc::TaskEvents &task_events) const {
+  size_t GetTaskListPriority(const rpc::TaskEvents &task_events) const override {
     if (IsTaskFinished(task_events)) {
       return 0;
     }