Skip to content

Commit c943181

Browse files
authored
Shrink wheel size limit following removal of vector search APIs. (#2509)
Following #2498, we can apply this feedback from #2490: #2490 (comment) These changes are inspired by rapidsai/cuvs#469. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2509
1 parent adfd2f6 commit c943181

File tree

4 files changed

+27
-5
lines changed

4 files changed

+27
-5
lines changed

ci/build_wheel_pylibraft.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ esac
1818
export SKBUILD_CMAKE_ARGS="-DDETECT_CONDA_ENV=OFF;-DFIND_RAFT_CPP=OFF${EXTRA_CMAKE_ARGS}"
1919

2020
ci/build_wheel.sh pylibraft ${package_dir}
21-
ci/validate_wheel.sh ${package_dir} final_dist
21+
ci/validate_wheel.sh ${package_dir} final_dist pylibraft

ci/build_wheel_raft_dask.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ package_dir="python/raft-dask"
99
export SKBUILD_CMAKE_ARGS="-DDETECT_CONDA_ENV=OFF;-DFIND_RAFT_CPP=OFF"
1010

1111
ci/build_wheel.sh raft-dask ${package_dir}
12-
ci/validate_wheel.sh ${package_dir} final_dist
12+
ci/validate_wheel.sh ${package_dir} final_dist raft-dask

ci/validate_wheel.sh

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,37 @@ set -euo pipefail
55

66
package_dir=$1
77
wheel_dir_relative_path=$2
8+
package_name=$3
9+
10+
RAPIDS_CUDA_MAJOR="${RAPIDS_CUDA_VERSION%%.*}"
11+
12+
# some packages are much larger on CUDA 11 than on CUDA 12
13+
if [[ "${package_name}" == "raft-dask" ]]; then
14+
PYDISTCHECK_ARGS=(
15+
--max-allowed-size-compressed '200M'
16+
)
17+
elif [[ "${package_name}" == "pylibraft" ]]; then
18+
if [[ "${RAPIDS_CUDA_MAJOR}" == "11" ]]; then
19+
PYDISTCHECK_ARGS=(
20+
--max-allowed-size-compressed '600M'
21+
)
22+
else
23+
PYDISTCHECK_ARGS=(
24+
--max-allowed-size-compressed '100M'
25+
)
26+
fi
27+
else
28+
echo "Unsupported package name: ${package_name}"
29+
exit 1
30+
fi
831

932
cd "${package_dir}"
1033

1134
rapids-logger "validate packages with 'pydistcheck'"
1235

1336
pydistcheck \
1437
--inspect \
38+
"${PYDISTCHECK_ARGS[@]}" \
1539
"$(echo ${wheel_dir_relative_path}/*.whl)"
1640

1741
rapids-logger "validate packages with 'twine'"

python/pylibraft/pyproject.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,10 @@ matrix-entry = "cuda_suffixed=true;use_cuda_wheels=true"
132132

133133
[tool.pydistcheck]
134134
select = [
135+
# NOTE: size threshold is managed via CLI args in CI scripts
135136
"distro-too-large-compressed",
136137
]
137138

138-
# detect when package size grows significantly
139-
max_allowed_size_compressed = '825M'
140-
141139
[tool.pytest.ini_options]
142140
filterwarnings = [
143141
"error",

0 commit comments

Comments
 (0)