Skip to content

Commit d9b73d3

Browse files
authored
Merge pull request #567 from wmaxey/patch-6
Update several components on Windows and fix missing CUDA components on 13.0+
2 parents e8975b8 + 66fae46 commit d9b73d3

File tree

6 files changed

+10
-7
lines changed

6 files changed

+10
-7
lines changed

.github/actions/test-windows-image/image-test.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ try {
3333
TestReturnCode
3434

3535
Write-Output "int main() {return 0;}" > .\test.cu
36-
nvcc .\test.cu
36+
nvcc -v .\test.cu
3737
TestReturnCode
3838
}
3939
catch {

windows/image/installers/install-cmake.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Fetch CMake
2-
Invoke-WebRequest -Uri "https://github.com/Kitware/CMake/releases/download/v3.31.6/cmake-3.31.6-windows-x86_64.msi" -OutFile "C:\cmake_installer.msi" -UseBasicParsing
2+
Invoke-WebRequest -Uri "https://github.com/Kitware/CMake/releases/download/v4.1.0/cmake-4.1.0-windows-x86_64.msi" -OutFile "C:\cmake_installer.msi" -UseBasicParsing
33
Start-Process -NoNewWindow -Wait -FilePath msiexec -ArgumentList "/i C:\cmake_installer.msi ADD_CMAKE_TO_PATH=All /qn"
44
Remove-Item "C:\cmake_installer.msi"
55

windows/image/installers/install-cuda.ps1

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ $cudaComponents =
3737

3838
if ("${major}" -ge "13") {
3939
$cudaComponents += "crt_$mmVersionTag"
40+
$cudaComponents += "cuobjdump_$mmVersionTag"
41+
$cudaComponents += "nvfatbin_$mmVersionTag"
42+
$cudaComponents += "nvjitlink_$mmVersionTag"
43+
$cudaComponents += "nvvm_$mmVersionTag"
44+
$cudaComponents += "nvptxcompiler_$mmVersionTag"
4045
}
4146

4247
Write-Output "Installing CUDA Components: ${cudaComponents}"

windows/image/installers/install-git.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Fetch git
2-
Invoke-WebRequest -Uri "https://github.com/git-for-windows/git/releases/download/v2.41.0.windows.3/Git-2.41.0.3-64-bit.exe" -OutFile "C:\git_installer.exe" -UseBasicParsing
2+
Invoke-WebRequest -Uri "https://github.com/git-for-windows/git/releases/download/v2.51.0.windows.1/Git-2.51.0-64-bit.exe" -OutFile "C:\git_installer.exe" -UseBasicParsing
33
Start-Process -NoNewWindow -Wait -FilePath "C:\git_installer.exe" -ArgumentList "/S /VERYSILENT /NORESTART /NOCANCEL /SP- /CLOSEAPPLICATIONS /RESTARTAPPLICATIONS"
44
Remove-Item "C:\git_installer.exe"
55

windows/image/installers/install-ninja.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Invoke-WebRequest -Uri "https://github.com/ninja-build/ninja/releases/download/v1.12.1/ninja-win.zip" -OutFile "./ninja.zip" -UseBasicParsing
1+
Invoke-WebRequest -Uri "https://github.com/ninja-build/ninja/releases/download/v1.13.1/ninja-win.zip" -OutFile "./ninja.zip" -UseBasicParsing
22
Expand-Archive .\ninja.zip
33

44
. "$PSScriptRoot/envvars.ps1"

windows/windows.Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG ROOT_IMAGE
22

3-
FROM $ROOT_IMAGE as PreCompilerEnv
3+
FROM $ROOT_IMAGE
44

55
SHELL ["powershell.exe"]
66

@@ -11,8 +11,6 @@ ADD ./ /tools
1111

1212
RUN /tools/install-tools.ps1 -cudaVersion $ENV:CUDA_VER
1313

14-
FROM PreCompilerEnv as BuildEnv
15-
1614
ARG MSVC_VER
1715
ARG MSVC_COMPILER_VER
1816

0 commit comments

Comments
 (0)