You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add "devcontainers" dependency file key that excludes xgboost (#7006)
Unified conda devcontainers use the `all` file key to generate their dependency lists for each repository. Currently cuml includes `xgboost` in its `all` file key via the `test_python` dependency list. Unfortunately, this pulls in a conda dependency on `librmm` via `libxgboost`. This is problematic because we must build `librmm` from source in our unified devcontainers.
It seems like `xgboost` is a soft test dependency. In this PR, I add a new dependency file key called `devcontainers` that excludes `xgboost`. Developer conda environments, CI workflows, and pip devcontainers are unaffected by this change. Conda devcontainers will now require the user to manually install `xgboost` in order to run tests that need it, and this is noted in `BUILD.md`.
This is needed to solve the problems discussed in rapidsai/devcontainers#534 (comment).
Once this is merged, I will push a change to rapidsai/devcontainers#536 to use the new `devcontainers` file key.
Authors:
- Bradley Dice (https://github.com/bdice)
Approvers:
- Paul Taylor (https://github.com/trxcllnt)
- James Lamb (https://github.com/jameslamb)
- Simon Adorf (https://github.com/csadorf)
URL: #7006
0 commit comments