Skip to content

Commit bb63fab

Browse files
pbstriker38rosa
authored andcommitted
Add test for inline styles
1 parent b89f01f commit bb63fab

File tree

3 files changed

+37
-0
lines changed

3 files changed

+37
-0
lines changed

Gemfile.lock

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,13 @@ GEM
116116
public_suffix (>= 2.0.2, < 6.0)
117117
ast (2.4.2)
118118
base64 (0.2.0)
119+
better_html (2.1.1)
120+
actionview (>= 6.0)
121+
activesupport (>= 6.0)
122+
ast (~> 2.0)
123+
erubi (~> 1.4)
124+
parser (>= 2.4)
125+
smart_properties
119126
bigdecimal (3.1.7)
120127
builder (3.2.4)
121128
concurrent-ruby (1.3.3)
@@ -301,6 +308,7 @@ GEM
301308
rack-protection (= 4.0.0)
302309
rack-session (>= 2.0.0, < 3)
303310
tilt (~> 2.0)
311+
smart_properties (1.17.0)
304312
sprockets (4.2.1)
305313
concurrent-ruby (~> 1.0)
306314
rack (>= 2.2.4, < 4)
@@ -345,6 +353,7 @@ PLATFORMS
345353
x86_64-linux
346354

347355
DEPENDENCIES
356+
better_html
348357
capybara!
349358
debug
350359
mission_control-jobs!

mission_control-jobs.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ Gem::Specification.new do |spec|
3333
spec.add_development_dependency "rubocop", "~> 1.52.0"
3434
spec.add_development_dependency "rubocop-performance"
3535
spec.add_development_dependency "rubocop-rails-omakase"
36+
spec.add_development_dependency "better_html"
3637
spec.add_development_dependency "sprockets-rails"
3738
spec.add_development_dependency "sqlite3"
3839
spec.add_development_dependency "puma"
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# frozen_string_literal: true
2+
3+
require "test_helper"
4+
require "better_html"
5+
require "better_html/parser"
6+
require "better_html/tree/tag"
7+
8+
class MissionControl::ErbInlineStylesTest < ActiveSupport::TestCase
9+
ERB_GLOB = Rails.root.join(
10+
"..", "..", "app", "views", "**", "{*.htm,*.html,*.htm.erb,*.html.erb,*.html+*.erb}"
11+
)
12+
13+
Dir[ERB_GLOB].each do |filename|
14+
pathname = Pathname.new(filename).relative_path_from(Rails.root)
15+
16+
test "No inline styles in /#{pathname.relative_path_from('../..')}" do
17+
buffer = Parser::Source::Buffer.new("")
18+
buffer.source = File.read(filename)
19+
parser = BetterHtml::Parser.new(buffer)
20+
21+
parser.nodes_with_type(:tag).each do |tag_node|
22+
tag = BetterHtml::Tree::Tag.from_node(tag_node)
23+
assert_nil tag.attributes["style"]
24+
end
25+
end
26+
end
27+
end

0 commit comments

Comments
 (0)