Skip to content

Commit ba46c2d

Browse files
authored
modify udt2udt test to remove unneccessary dependency on configmap (#9923)
# Description current strategy does not take care of the order in which resources are created. so if configmap was not created before the udt, then the test errors out. removing this dependency. ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: <!-- This checklist uses "TaskRadio" comments to make certain options mutually exclusive. See: https://github.com/mheap/require-checklist-action?tab=readme-ov-file#radio-groups For details on how this works and why it's required. --> - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [X] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes <!-- TaskRadio design-pr --> - [X] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [X] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [X] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [X] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [X] Not applicable <!-- TaskRadio recipes-pr --> --------- Signed-off-by: nithyatsu <[email protected]>
1 parent 28952d0 commit ba46c2d

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

test/functional-portable/dynamicrp/noncloud/resources/testdata/udt2udt-connection-tf.bicep

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,6 @@ resource udttoudtchild 'Test.Resources/externalResource@2023-10-01-preview' = {
6767
properties: {
6868
environment: udttoudtenv.id
6969
application: udttoudtapp.id
70-
configMap: string(udttoudttfcfgmap.data)
71-
}
72-
}
73-
74-
resource udttoudttfcfgmap 'core/ConfigMap@v1' = {
75-
metadata: {
76-
name: 'udttoudttfcfgmap'
77-
}
78-
data: {
79-
'app1.sample.properties': 'property1=value1\nproperty2=value2'
80-
'app2.sample.properties': 'property3=value3\nproperty4=value4'
70+
configMap: '{"app1.sample.properties":"property1=value1\\nproperty2=value2","app2.sample.properties":"property3=value3\\nproperty4=value4"}'
8171
}
8272
}

test/functional-portable/dynamicrp/noncloud/resources/testdata/udt2udt-connection.bicep

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,6 @@ resource udttoudtchild 'Test.Resources/externalResource@2023-10-01-preview' = {
7070
properties: {
7171
environment: udttoudtenv.id
7272
application: udttoudtapp.id
73-
configMap: string(udttoudtcfgmap.data)
74-
}
75-
}
76-
77-
resource udttoudtcfgmap 'core/ConfigMap@v1' = {
78-
metadata: {
79-
name: 'udttoudtcfgmap'
80-
}
81-
data: {
82-
'app1.sample.properties': 'property1=value1\nproperty2=value2'
83-
'app2.sample.properties': 'property3=value3\nproperty4=value4'
73+
configMap: '{"app1.sample.properties":"property1=value1\\nproperty2=value2","app2.sample.properties":"property3=value3\\nproperty4=value4"}'
8474
}
8575
}

0 commit comments

Comments
 (0)