Skip to content

Commit 23f10fc

Browse files
Merge pull request #8822 from rabbitmq/mergify/bp/v3.12.x/pr-8820
Naming follow-up to #8790 (backport #8820)
2 parents 789803a + a572fd1 commit 23f10fc

File tree

7 files changed

+26
-18
lines changed

7 files changed

+26
-18
lines changed

deps/rabbitmq_web_mqtt/priv/schema/rabbitmq_web_mqtt.schema

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ end}.
186186
%% File Handle Cache
187187
%%
188188

189-
{mapping, "web_mqtt.enable_file_handle_cache", "rabbitmq_web_mqtt.enable_file_handle_cache",
189+
{mapping, "web_mqtt.use_file_handle_cache", "rabbitmq_web_mqtt.use_file_handle_cache",
190190
[
191191
{datatype, {enum, [true, false]}}
192192
]}.

deps/rabbitmq_web_mqtt/src/rabbit_web_mqtt_handler.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ init(Req, Opts) ->
7979
false ->
8080
no_supported_sub_protocol(Protocol, Req);
8181
true ->
82-
ShouldUseFHC = application:get_env(?APP, enable_file_handle_cache, true),
82+
ShouldUseFHC = application:get_env(?APP, use_file_handle_cache, true),
8383
case ShouldUseFHC of
8484
true -> ?LOG_INFO("Web MQTT: file handle cache use is enabled");
8585
false -> ?LOG_INFO("Web MQTT: file handle cache use is disabled")

deps/rabbitmq_web_mqtt/test/config_schema_SUITE_data/rabbitmq_web_mqtt.snippets

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,16 @@
4848
[{max_connections, 5000}]}],
4949
[rabbitmq_web_mqtt]},
5050

51-
{enable_file_handle_cache_is_disabled,
52-
"web_mqtt.enable_file_handle_cache = false",
51+
{use_file_handle_cache_is_off,
52+
"web_mqtt.use_file_handle_cache = false",
5353
[{rabbitmq_web_mqtt,
54-
[{enable_file_handle_cache, false}]}],
54+
[{use_file_handle_cache, false}]}],
5555
[rabbitmq_web_mqtt]},
5656

57-
{enable_file_handle_cache_is_enabled,
58-
"web_mqtt.enable_file_handle_cache = true",
57+
{use_file_handle_cache_is_on,
58+
"web_mqtt.use_file_handle_cache = true",
5959
[{rabbitmq_web_mqtt,
60-
[{enable_file_handle_cache, true}]}],
60+
[{use_file_handle_cache, true}]}],
6161
[rabbitmq_web_mqtt]},
6262

6363
{ssl_listener,

deps/rabbitmq_web_stomp/priv/schema/rabbitmq_web_stomp.schema

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ end}.
194194
%% File Handle Cache
195195
%%
196196

197-
{mapping, "web_stomp.enable_file_handle_cache", "rabbitmq_web_stomp.enable_file_handle_cache",
197+
{mapping, "web_stomp.use_file_handle_cache", "rabbitmq_web_stomp.use_file_handle_cache",
198198
[
199199
{datatype, {enum, [true, false]}}
200200
]}.

deps/rabbitmq_web_stomp/src/rabbit_web_stomp_handler.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ init(Req0, Opts) ->
8585
end,
8686
WsOpts0 = proplists:get_value(ws_opts, Opts, #{}),
8787
WsOpts = maps:merge(#{compress => true}, WsOpts0),
88-
ShouldUseFHC = application:get_env(?APP, enable_file_handle_cache, true),
88+
ShouldUseFHC = application:get_env(?APP, use_file_handle_cache, true),
8989
case ShouldUseFHC of
9090
true -> ?LOG_INFO("Web STOMP: file handle cache use is enabled");
9191
false -> ?LOG_INFO("Web STOMP: file handle cache use is disabled")

deps/rabbitmq_web_stomp/test/config_schema_SUITE_data/rabbitmq_web_stomp.snippets

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,16 @@
4242
[{max_connections, 5000}]}],
4343
[rabbitmq_web_stomp]},
4444

45-
{enable_file_handle_cache_is_disabled,
46-
"web_stomp.enable_file_handle_cache = false",
45+
{use_file_handle_cache_is_off,
46+
"web_stomp.use_file_handle_cache = false",
4747
[{rabbitmq_web_stomp,
48-
[{enable_file_handle_cache, false}]}],
48+
[{use_file_handle_cache, false}]}],
4949
[rabbitmq_web_stomp]},
5050

51-
{enable_file_handle_cache_is_enabled,
52-
"web_stomp.enable_file_handle_cache = true",
51+
{use_file_handle_cache_is_on,
52+
"web_stomp.use_file_handle_cache = true",
5353
[{rabbitmq_web_stomp,
54-
[{enable_file_handle_cache, true}]}],
54+
[{use_file_handle_cache, true}]}],
5555
[rabbitmq_web_stomp]},
5656

5757
{ssl_listener,

release-notes/3.12.2.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,11 @@ Release notes can be found on GitHub at [rabbitmq-server/release-notes](https://
115115

116116
#### Enhacements
117117

118-
* It is now possible to opt in to deactivate file handle cache use in the plugin.
118+
* It is now possible to opt in to deactivate file handle cache use in the plugin:
119+
120+
``` ini
121+
web_mqtt.use_file_handle_cache = false
122+
```
119123

120124
GitHub issue: [#8790](https://github.com/rabbitmq/rabbitmq-server/pull/8790)
121125

@@ -124,7 +128,11 @@ Release notes can be found on GitHub at [rabbitmq-server/release-notes](https://
124128

125129
#### Enhacements
126130

127-
* It is now possible to opt in to deactivate file handle cache use in the plugin.
131+
* It is now possible to opt in to deactivate file handle cache use in the plugin:
132+
133+
``` ini
134+
web_stomp.use_file_handle_cache = false
135+
```
128136

129137
GitHub issue: [#8790](https://github.com/rabbitmq/rabbitmq-server/pull/8790)
130138

0 commit comments

Comments
 (0)